linux-kernel - Re: [PATCH v2 1/2] dt-bindings: media: i2c: Add ov2735 sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae032226-8e0d-4355-828e-4a5e0b0473b8@kernel.org>
Date: Tue, 8 Jul 2025 12:41:15 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>,
 sakari.ailus@...ux.intel.com, andriy.shevchenko@...ux.intel.com,
 krzk+dt@...nel.org
Cc: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Hans Verkuil <hverkuil@...all.nl>,
 Ricardo Ribalda <ribalda@...omium.org>, André Apitzsch
 <git@...tzsch.eu>, Hans de Goede <hansg@...nel.org>,
 Sylvain Petinot <sylvain.petinot@...s.st.com>,
 Jingjing Xiong <jingjing.xiong@...el.com>,
 Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
 Dongcheng Yan <dongcheng.yan@...el.com>,
 Heimir Thor Sverrisson <heimir.sverrisson@...il.com>,
 Matthias Fend <matthias.fend@...end.at>, Arnd Bergmann <arnd@...db.de>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 You-Sheng Yang <vicamo.yang@...onical.com>, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: media: i2c: Add ov2735 sensor

On 08/07/2025 12:25, Hardevsinh Palaniya wrote:
> +
> +  clocks:
> +    items:
> +      - description: XVCLK clock
> +
> +  clock-names:
> +    items:
> +      - const: xvclk
> +
> +  AVDD-supply:

Use lowercase everywhere.

> +    description: Analog Domain Power Supply
> +
> +  DOVDD-supply:
> +    description: I/O Domain Power Supply
> +
> +  DVDD-supply:
> +    description: Digital Domain Power Supply
> +
> +  reset-gpios:
> +    maxItems: 1
> +    description: Reset Pin GPIO Control (active low)
> +
> +  pwdn-gpios:

Use instead recommended name from the gpio-consumer-common.yaml.

> +    maxItems: 1
> +    description: Powerdown Pin GPIO Control (active low)
> +
> +  port:
> +    description: MIPI CSI-2 transmitter port
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    additionalProperties: false
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          data-lanes:
> +            items:
> +              - const: 1
> +              - const: 2
> +
> +        required:
> +          - data-lanes
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - port


Supplies should be required. Devices rarely work without power.


Best regards,
Krzysztof