linux-kernel - Re: [PATCH v2 2/2] media: i2c: add ov2735 image sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca6d8433-6ce7-46a9-8c16-11845f87402b@kernel.org>
Date: Tue, 8 Jul 2025 12:42:55 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>,
 sakari.ailus@...ux.intel.com, andriy.shevchenko@...ux.intel.com,
 krzk+dt@...nel.org
Cc: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Hans Verkuil <hverkuil@...all.nl>,
 André Apitzsch <git@...tzsch.eu>,
 Hans de Goede <hansg@...nel.org>, Ricardo Ribalda <ribalda@...omium.org>,
 Heimir Thor Sverrisson <heimir.sverrisson@...il.com>,
 Matthias Fend <matthias.fend@...end.at>,
 Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
 Jingjing Xiong <jingjing.xiong@...el.com>,
 Sylvain Petinot <sylvain.petinot@...s.st.com>,
 Dongcheng Yan <dongcheng.yan@...el.com>, Arnd Bergmann <arnd@...db.de>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] media: i2c: add ov2735 image sensor driver

On 08/07/2025 12:25, Hardevsinh Palaniya wrote:
> +
> +static const struct v4l2_subdev_ops ov2735_subdev_ops = {
> +	.video = &ov2735_video_ops,
> +	.pad = &ov2735_pad_ops,
> +};
> +
> +static const struct v4l2_subdev_internal_ops ov2735_internal_ops = {
> +	.init_state = ov2735_init_state,
> +};
> +
> +static int ov2735_power_on(struct device *dev)
> +{
> +	struct v4l2_subdev *sd = dev_get_drvdata(dev);
> +	struct ov2735 *ov2735 = to_ov2735(sd);
> +	unsigned long delay_us;
> +	int ret;
> +
> +	gpiod_set_value_cansleep(ov2735->pwdn_gpio, 0);

So you power up here...

> +	fsleep(3000);
> +
> +	ret = regulator_bulk_enable(ARRAY_SIZE(ov2735_supply_name),
> +				    ov2735->supplies);
> +	if (ret) {
> +		dev_err(ov2735->dev, "failed to enable regulators\n");
> +		return ret;
> +	}
> +
> +	gpiod_set_value_cansleep(ov2735->pwdn_gpio, 1);

And here you power down your device. This makes no sense... unless this
is not a power down GPIO.


Best regards,
Krzysztof