linux-kernel - Re: [PATCH] ASoC: SDCA: fix HID dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0b385401-2291-4cc8-b10c-6e7f449724ec@app.fastmail.com>
Date: Wed, 09 Jul 2025 17:13:05 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Charles Keepax" <ckeepax@...nsource.cirrus.com>
Cc: "Arnd Bergmann" <arnd@...nel.org>,
 "Maciej Strozek" <mstrozek@...nsource.cirrus.com>,
 "Liam Girdwood" <lgirdwood@...il.com>, "Mark Brown" <broonie@...nel.org>,
 "Jaroslav Kysela" <perex@...ex.cz>, "Takashi Iwai" <tiwai@...e.com>,
 "Shuming Fan" <shumingf@...ltek.com>,
 "Bard Liao" <yung-chuan.liao@...ux.intel.com>,
 "Pierre-Louis Bossart" <pierre-louis.bossart@...ux.dev>,
 "Peter Ujfalusi" <peter.ujfalusi@...ux.intel.com>,
 "Kuninori Morimoto" <kuninori.morimoto.gx@...esas.com>,
 linux-sound@...r.kernel.org, patches@...nsource.cirrus.com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: SDCA: fix HID dependency

On Wed, Jul 9, 2025, at 17:04, Charles Keepax wrote:
> On Wed, Jul 09, 2025 at 03:36:49PM +0200, Arnd Bergmann wrote:
>> On Wed, Jul 9, 2025, at 14:38, Charles Keepax wrote:
>> > On Tue, Jul 08, 2025 at 08:46:06PM +0200, Arnd Bergmann wrote:
>> It could work, but then the 'depends on HID || !HID' would
>> need to be under SND_SST_ATOM_HIFI2_PLATFORM_ACPI and anything
>> else that might select SND_SOC_ACPI_INTEL_MATCH,
>> SND_SOC_ACPI_INTEL_SDCA_QUIRKS, or SND_SOC_SDCA in the future.
>
> Ah yes I forgot things are selected by the Intel stuff, at least
> the double depends on HID can be changed though? ie.
>
> depends on SND_SOC_SDCA
> depends on HID=y || HID=SND_SOC_SDCA

Yes, that functionally the same, I wasn't sure which one
you'd prefer. Let me know if I should send a v2.

     Arnd