linux-kernel - Re: [PATCH] ASoC: SDCA: fix HID dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aG6FFXrfOnBlnn1l@opensource.cirrus.com>
Date: Wed, 9 Jul 2025 16:04:53 +0100
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Arnd Bergmann <arnd@...db.de>
Cc: Arnd Bergmann <arnd@...nel.org>,
        Maciej Strozek <mstrozek@...nsource.cirrus.com>,
        Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Shuming Fan <shumingf@...ltek.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>,
        Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        linux-sound@...r.kernel.org, patches@...nsource.cirrus.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: SDCA: fix HID dependency

On Wed, Jul 09, 2025 at 03:36:49PM +0200, Arnd Bergmann wrote:
> On Wed, Jul 9, 2025, at 14:38, Charles Keepax wrote:
> > On Tue, Jul 08, 2025 at 08:46:06PM +0200, Arnd Bergmann wrote:
> >>  
> >>  config SND_SOC_SDCA_HID
> >> -	tristate "SDCA HID support"
> >> +	bool "SDCA HID support"
> >>  	depends on SND_SOC_SDCA && HID
> >> +	depends on HID=y || HID=SND_SOC_SDCA
> >
> > Does it perhaps make more sense to add a (HID || !HID) dependency
> > on SND_SOC_SDCA and leave the dependencies here alone? I feel
> > like that lets the Kconfig figure out the right settings for
> > SND_SOC_SDCA automatically, rather than just disappearing the SDCA
> > HID option when HID and SDCA are set incompatibly.
> 
> The problem is that SND_SOC_SDCA is not a user-visible option
> but instead gets selected by SND_SOC_ACPI_INTEL_SDCA_QUIRKS,
> which itself gets selected indirectly.
> 
> It could work, but then the 'depends on HID || !HID' would
> need to be under SND_SST_ATOM_HIFI2_PLATFORM_ACPI and anything
> else that might select SND_SOC_ACPI_INTEL_MATCH,
> SND_SOC_ACPI_INTEL_SDCA_QUIRKS, or SND_SOC_SDCA in the future.

Ah yes I forgot things are selected by the Intel stuff, at least
the double depends on HID can be changed though? ie.

depends on SND_SOC_SDCA
depends on HID=y || HID=SND_SOC_SDCA

Thanks,
Charles