linux-kernel - RE: [Intel-wired-lan] [PATCH v2] e1000e: Populate entire system_counterval_t in get_time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8986940A36E601871BFCCEC5E549A@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Wed, 9 Jul 2025 18:03:29 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: Markus Blöchl <markus@...chl.de>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, Richard Cochran <richardcochran@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>
CC: Lakshmi Sowjanya D <lakshmi.sowjanya.d@...el.com>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, "Bloechl, Markus" <markus.bloechl@...tronik.com>, "John
 Stultz" <jstultz@...gle.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH v2] e1000e: Populate entire
 system_counterval_t in get_time_fn() callback



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Markus Blöchl
> Sent: Wednesday, July 9, 2025 7:28 PM
> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@...el.com>; Richard Cochran
> <richardcochran@...il.com>; Thomas Gleixner <tglx@...utronix.de>
> Cc: Lakshmi Sowjanya D <lakshmi.sowjanya.d@...el.com>; Andrew Lunn
> <andrew+netdev@...n.ch>; David S. Miller <davem@...emloft.net>; Eric
> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
> Abeni <pabeni@...hat.com>; Bloechl, Markus
> <markus.bloechl@...tronik.com>; John Stultz <jstultz@...gle.com>;
> intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; Markus Blöchl <markus@...chl.de>
> Subject: [Intel-wired-lan] [PATCH v2] e1000e: Populate entire
> system_counterval_t in get_time_fn() callback
> 
> get_time_fn() callback implementations are expected to fill out the
> entire system_counterval_t struct as it may be initially
> uninitialized.
> 
> This broke with the removal of convert_art_to_tsc() helper functions
> which left use_nsecs uninitialized.
> 
> Assign the entire struct again.
> 
> Fixes: bd48b50be50a ("e1000e: Replace convert_art_to_tsc()")
> Cc: stable@...r.kernel.org
> Signed-off-by: Markus Blöchl <markus@...chl.de>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>

> ---
> Notes:
>     Related-To:
> <https://lore.kernel.org/lkml/txyrr26hxe3xpq3ebqb5ewkgvhvp7xalotaouwlu
> djtjifnah2@...gczln4aoo/>
> 
> Changes in v2:
> - Add Lakshmi in Cc:
> - Add Signed-off-by: trailer which was lost in b4 workflow
> - Link to v1: https://lore.kernel.org/r/20250709-e1000e_crossts-v1-1-
> f8a80c792e4f@...chl.de
> ---
>  drivers/net/ethernet/intel/e1000e/ptp.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/e1000e/ptp.c
> b/drivers/net/ethernet/intel/e1000e/ptp.c
> index
> ea3c3eb2ef2020d513d49c1368679f27d17edb04..f01506504ee3a11822930115e9ed
> 07661d81532c 100644
> --- a/drivers/net/ethernet/intel/e1000e/ptp.c
> +++ b/drivers/net/ethernet/intel/e1000e/ptp.c
> @@ -124,8 +124,11 @@ static int e1000e_phc_get_syncdevicetime(ktime_t
> *device,
>  	sys_cycles = er32(PLTSTMPH);
>  	sys_cycles <<= 32;
>  	sys_cycles |= er32(PLTSTMPL);
> -	system->cycles = sys_cycles;
> -	system->cs_id = CSID_X86_ART;
> +	*system = (struct system_counterval_t) {
> +		.cycles = sys_cycles,
> +		.cs_id = CSID_X86_ART,
> +		.use_nsecs = false,
> +	};
> 
>  	return 0;
>  }
> 
> ---
> base-commit: 733923397fd95405a48f165c9b1fbc8c4b0a4681
> change-id: 20250709-e1000e_crossts-7745674f682a
> 
> Best regards,
> --
> Markus Blöchl <markus@...chl.de>