linux-kernel - Re: [PATCH 1/2] i2c: omap: Handle omap_i2c_init() errors in omap_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aG60GJy60Jf3w8tZ@roadster.musicnaut.iki.fi>
Date: Wed, 9 Jul 2025 21:25:28 +0300
From: Aaro Koskinen <aaro.koskinen@....fi>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: vigneshr@...com, andreas@...nade.info, khilman@...libre.com,
	rogerq@...nel.org, tony@...mide.com, jmkrzyszt@...il.com,
	andi.shyti@...nel.org, miaoqinglang@...wei.com,
	grygorii.strashko@...com, wsa@...nel.org,
	Jean Delvare <khali@...ux-fr.org>,
	Komal Shah <komal_shah802003@...oo.com>,
	Greg Kroah-Hartman <gregkh@...e.de>, linux-omap@...r.kernel.org,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/2] i2c: omap: Handle omap_i2c_init() errors in
 omap_i2c_probe()

Hi,

On Sat, Jul 05, 2025 at 09:57:37AM +0200, Christophe JAILLET wrote:
> omap_i2c_init() can fail. Handle this error in omap_i2c_probe().
> 
> Fixes: 010d442c4a29 ("i2c: New bus driver for TI OMAP boards")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Compile tested only.
> ---
>  drivers/i2c/busses/i2c-omap.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index 8b01df3cc8e9..485313d872e5 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -1472,7 +1472,11 @@ omap_i2c_probe(struct platform_device *pdev)
>  	}
>  
>  	/* reset ASAP, clearing any IRQs */
> -	omap_i2c_init(omap);
> +	r = omap_i2c_init(omap);
> +	if (r) {
> +		dev_err(omap->dev, "failure to initialize i2c: %d\n", r);

Error paths in omap_i2c_init already print a message and error code,
so this is log is redundant.

A.

> +		goto err_mux_state_deselect;
> +	}
>  
>  	if (omap->rev < OMAP_I2C_OMAP1_REV_2)
>  		r = devm_request_irq(&pdev->dev, omap->irq, omap_i2c_omap1_isr,
> @@ -1515,6 +1519,7 @@ omap_i2c_probe(struct platform_device *pdev)
>  
>  err_unuse_clocks:
>  	omap_i2c_write_reg(omap, OMAP_I2C_CON_REG, 0);
> +err_mux_state_deselect:
>  	if (omap->mux_state)
>  		mux_state_deselect(omap->mux_state);
>  err_put_pm:
> -- 
> 2.50.0
> 
>