linux-kernel - Re: [PATCH 1/2] i2c: omap: Handle omap_i2c_init() errors in omap_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <joo6ibjqnsriouiw77fwc5kd2p2wd2junhlhe5nzivzot2jgac@q33qj637wt53>
Date: Wed, 9 Jul 2025 21:03:10 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Aaro Koskinen <aaro.koskinen@....fi>
Cc: Christophe JAILLET <christophe.jaillet@...adoo.fr>, vigneshr@...com, 
	andreas@...nade.info, khilman@...libre.com, rogerq@...nel.org, tony@...mide.com, 
	jmkrzyszt@...il.com, miaoqinglang@...wei.com, grygorii.strashko@...com, 
	wsa@...nel.org, Jean Delvare <khali@...ux-fr.org>, 
	Komal Shah <komal_shah802003@...oo.com>, Greg Kroah-Hartman <gregkh@...e.de>, linux-omap@...r.kernel.org, 
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/2] i2c: omap: Handle omap_i2c_init() errors in
 omap_i2c_probe()

Hi Aaro,

> > diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> > index 8b01df3cc8e9..485313d872e5 100644
> > --- a/drivers/i2c/busses/i2c-omap.c
> > +++ b/drivers/i2c/busses/i2c-omap.c
> > @@ -1472,7 +1472,11 @@ omap_i2c_probe(struct platform_device *pdev)
> >  	}
> >  
> >  	/* reset ASAP, clearing any IRQs */
> > -	omap_i2c_init(omap);
> > +	r = omap_i2c_init(omap);
> > +	if (r) {
> > +		dev_err(omap->dev, "failure to initialize i2c: %d\n", r);
> 
> Error paths in omap_i2c_init already print a message and error code,
> so this is log is redundant.

Good point! I will take care of it, no need to send a v2.

Thanks,
Andi