linux-kernel - Re: [PATCH V2] media: i2c: Kconfig: Ensure a dependency on COMMON_CLK for VIDEO_CAMERA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aG7UWg8kYMNX32MS@kekkonen.localdomain>
Date: Wed, 9 Jul 2025 20:43:06 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Mehdi Djait <mehdi.djait@...ux.intel.com>
Cc: laurent.pinchart@...asonboard.com, jacopo.mondi@...asonboard.com,
	hverkuil@...all.nl, kieran.bingham@...asonboard.com,
	mchehab@...nel.org, hdegoede@...hat.com, arnd@...db.de,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] media: i2c: Kconfig: Ensure a dependency on
 COMMON_CLK for VIDEO_CAMERA_SENSOR

Hi Mehdi,

Thanks for the update.

On Wed, Jul 09, 2025 at 12:11:14PM +0200, Mehdi Djait wrote:
> Both ACPI and DT-based systems are required to obtain the external
> camera sensor clock using the new devm_v4l2_sensor_clk_get() helper
> function.
> 
> Ensure a dependency on COMMON_CLK when config VIDEO_CAMERA_SENSOR is
> enabled.
> 
> Signed-off-by: Mehdi Djait <mehdi.djait@...ux.intel.com>
> ---
> v1 -> v2:
> Suggested by Arnd Bergmann:
> 	- removed the select statement and replaced it by "depends on
> 	  COMMON_CLK"
> 
> Link v1: https://lore.kernel.org/linux-media/20250708161637.227111-1-mehdi.djait@linux.intel.com
> 
>  drivers/media/i2c/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index e68202954a8f..98750fa5a7b6 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -27,7 +27,7 @@ config VIDEO_IR_I2C
>  
>  menuconfig VIDEO_CAMERA_SENSOR
>  	bool "Camera sensor devices"
> -	depends on MEDIA_CAMERA_SUPPORT && I2C
> +	depends on MEDIA_CAMERA_SUPPORT && I2C && COMMON_CLK

As of now, this patch makes COMMON_CLK a requirement to use camera sensors.
I think you should depend on COMMON_CLK only on ACPI-based platforms as
non-CCF clock implementations are still in use and these platforms do not
use ACPI.

>  	select MEDIA_CONTROLLER
>  	select V4L2_FWNODE
>  	select VIDEO_V4L2_SUBDEV_API

-- 
Regards,

Sakari Ailus