linux-kernel - Re: [PATCH V2] media: i2c: Kconfig: Ensure a dependency on COMMON_CLK for VIDEO_CAMERA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <7bd357f9-9964-431b-a3b2-932cf159cd25@app.fastmail.com>
Date: Thu, 10 Jul 2025 08:16:03 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Sakari Ailus" <sakari.ailus@...ux.intel.com>,
 "Mehdi Djait" <mehdi.djait@...ux.intel.com>
Cc: "laurent.pinchart" <laurent.pinchart@...asonboard.com>,
 "Jacopo Mondi" <jacopo.mondi@...asonboard.com>,
 "Hans Verkuil" <hverkuil@...all.nl>,
 "Kieran Bingham" <kieran.bingham@...asonboard.com>,
 "Mauro Carvalho Chehab" <mchehab@...nel.org>,
 "Hans de Goede" <hdegoede@...hat.com>, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] media: i2c: Kconfig: Ensure a dependency on COMMON_CLK for
 VIDEO_CAMERA_SENSOR

On Wed, Jul 9, 2025, at 22:43, Sakari Ailus wrote:
> On Wed, Jul 09, 2025 at 12:11:14PM +0200, Mehdi Djait wrote:

>> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
>> index e68202954a8f..98750fa5a7b6 100644
>> --- a/drivers/media/i2c/Kconfig
>> +++ b/drivers/media/i2c/Kconfig
>> @@ -27,7 +27,7 @@ config VIDEO_IR_I2C
>>  
>>  menuconfig VIDEO_CAMERA_SENSOR
>>  	bool "Camera sensor devices"
>> -	depends on MEDIA_CAMERA_SUPPORT && I2C
>> +	depends on MEDIA_CAMERA_SUPPORT && I2C && COMMON_CLK
>
> As of now, this patch makes COMMON_CLK a requirement to use camera sensors.
> I think you should depend on COMMON_CLK only on ACPI-based platforms as
> non-CCF clock implementations are still in use and these platforms do not
> use ACPI.

You are right, I mistakenly assumed that none of the HAVE_LEGACY_CLK
users supported any camera sensors, but after double-checking I see
that there are three camera sensor drivers (mt9t112, ov772x, rj54n1cb0c)
that are used on four SH772x (SH-4A) boards.

I could not find any possible use of VIDEO_CAMERA_SENSOR on
architectures that don't already mandate COMMON_CLK. There
is also no way you'd have the combination of ACPI and HAVE_LEGACY_CLK,
so it would be sufficient to check for 'depends on HAVE_CLK',
or we could limit it further using 'depends on COMMON_CLK ||
(SH && ARCH_SHMOBILE)'.

     Arnd