linux-kernel - Re: [PATCH] PCI: endpoint: pci-epf-vntb: Fix the incorrect usage of _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aG7byxE2UmzpIQr3@lizhi-Precision-Tower-5810>
Date: Wed, 9 Jul 2025 17:14:51 -0400
From: Frank Li <Frank.li@....com>
To: Manivannan Sadhasivam <mani@...nel.org>
Cc: jdmason@...zu.us, dave.jiang@...el.com, allenbh@...il.com,
	kwilczynski@...nel.org, bhelgaas@...gle.com, ntb@...ts.linux.dev,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: endpoint: pci-epf-vntb: Fix the incorrect usage of
 __iomem attribute

On Wed, Jul 09, 2025 at 06:20:22PM +0530, Manivannan Sadhasivam wrote:
> __iomem attribute is supposed to be used only with variables holding the
> MMIO pointer. But here, 'mw_addr' variable is just holding a 'void *'
> returned by pci_epf_alloc_space(). So annotating it with __iomem is clearly
> wrong. Hence, drop the attribute.
>
> This also fixes the below sparse warning:
>
>   drivers/pci/endpoint/functions/pci-epf-vntb.c:524:17: warning: incorrect type in assignment (different address spaces)
>   drivers/pci/endpoint/functions/pci-epf-vntb.c:524:17:    expected void [noderef] __iomem *mw_addr
>   drivers/pci/endpoint/functions/pci-epf-vntb.c:524:17:    got void *
>   drivers/pci/endpoint/functions/pci-epf-vntb.c:530:21: warning: incorrect type in assignment (different address spaces)
>   drivers/pci/endpoint/functions/pci-epf-vntb.c:530:21:    expected unsigned int [usertype] *epf_db
>   drivers/pci/endpoint/functions/pci-epf-vntb.c:530:21:    got void [noderef] __iomem *mw_addr
>   drivers/pci/endpoint/functions/pci-epf-vntb.c:542:38: warning: incorrect type in argument 2 (different address spaces)
>   drivers/pci/endpoint/functions/pci-epf-vntb.c:542:38:    expected void *addr
>   drivers/pci/endpoint/functions/pci-epf-vntb.c:542:38:    got void [noderef] __iomem *mw_addr
>
> Fixes: e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP")
> Signed-off-by: Manivannan Sadhasivam <mani@...nel.org>

Reviewed-by: Frank Li <Frank.Li@....com>

> ---
>  drivers/pci/endpoint/functions/pci-epf-vntb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> index ac83a6dc6116..83e9ab10f9c4 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> @@ -512,7 +512,7 @@ static int epf_ntb_db_bar_init(struct epf_ntb *ntb)
>  	struct device *dev = &ntb->epf->dev;
>  	int ret;
>  	struct pci_epf_bar *epf_bar;
> -	void __iomem *mw_addr;
> +	void *mw_addr;
>  	enum pci_barno barno;
>  	size_t size = sizeof(u32) * ntb->db_count;
>
> --
> 2.45.2
>