linux-kernel - Re: [PATCH v3 3/3] dt-bindings: leds: issi,is31fl3236: add issi,22kHz-pwm property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250709-beagle-of-algebraic-enterprise-e9bec1@krzk-bin>
Date: Wed, 9 Jul 2025 10:19:52 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pawel Zalewski <pzalewski@...goodpenguin.co.uk>
Cc: Lee Jones <lee@...nel.org>, Pavel Machek <pavel@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Pavel Machek <pavel@....cz>, devicetree@...r.kernel.org
Subject: Re: [PATCH v3 3/3] dt-bindings: leds: issi,is31fl3236: add
 issi,22kHz-pwm property

On Tue, Jul 08, 2025 at 03:59:47PM +0100, Pawel Zalewski wrote:
> Add an additional and optional control property for setting
> the output PWM frequency to 22kHz. The default is 3kHz and
> this option puts the operational frequency outside of the
> audible range.
> 
> Signed-off-by: Pawel Zalewski <pzalewski@...goodpenguin.co.uk>
> ---
>  Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml b/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml
> index d0f9add5af01ac06c4bb87b0cd0faec71d0ef37c..5bce0fc48f84c7ae804e6522e312c51ed2d77bc5 100644
> --- a/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml
> +++ b/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml
> @@ -42,6 +42,12 @@ properties:
>    "#size-cells":
>      const: 0
>  
> +  issi,22kHz-pwm:
> +    type: boolean
> +    description:
> +      When present, the chip's PWM will operate at ~22kHz as opposed
> +      to ~3kHz to move the operating frequency out of the audible range.
> +

According to your driver this is not applicable to every device, so you
need allOf:if:then: block at the end, before additionalProperties,
restricting it per variant:

.....
  then:
    properties:
      issi,22kHz-pwm: false

If that's not true, then commit msg should explain that - from the
hardware perspective.

Best regards,
Krzysztof