linux-kernel - Re: [PATCH v3 2/3] dt-bindings: leds: is31fl32xx: convert the binding to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250709-happy-gazelle-of-fascination-fe0fd4@krzk-bin>
Date: Wed, 9 Jul 2025 10:17:47 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pawel Zalewski <pzalewski@...goodpenguin.co.uk>
Cc: Lee Jones <lee@...nel.org>, Pavel Machek <pavel@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Pavel Machek <pavel@....cz>, devicetree@...r.kernel.org, 
	Lucca Fachinetti <luccafachinetti@...il.com>
Subject: Re: [PATCH v3 2/3] dt-bindings: leds: is31fl32xx: convert the
 binding to yaml

On Tue, Jul 08, 2025 at 03:59:46PM +0100, Pawel Zalewski wrote:
> From: Lucca Fachinetti <luccafachinetti@...il.com>
> 
> Keep the old maintainers field as is.
> Add datasheets for reference, NB that I was not able to find an
> up-to-date, funtional direct URL for si-en products datasheet
> so they were skipped.
> 
> Signed-off-by: Lucca Fachinetti <luccafachinetti@...il.com>
> Co-developed-by: Pawel Zalewski <pzalewski@...goodpenguin.co.uk>
> Signed-off-by: Pawel Zalewski <pzalewski@...goodpenguin.co.uk>
> ---
>  .../devicetree/bindings/leds/issi,is31fl3236.yaml  | 98 ++++++++++++++++++++++
>  .../devicetree/bindings/leds/leds-is31fl32xx.txt   | 52 ------------
>  2 files changed, 98 insertions(+), 52 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml b/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..d0f9add5af01ac06c4bb87b0cd0faec71d0ef37c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml
> @@ -0,0 +1,98 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/issi,is31fl3236.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: is31fl32xx and Si-En SN32xx IC LED driver

Driver as Linux driver or LED driver? If the first, then drop.

> +
> +maintainers:
> +  - Pavel Machek <pavel@....cz>
> +  - Lee Jones <lee@...nel.org>

These should be people interested in this hardware, not subsystem
maintainers.

> +
> +description: |
> +  The is31fl32xx/SN32xx family of LED drivers are I2C devices with multiple
> +  constant-current channels, each with independent 256-level PWM control.
> +  Each LED is represented as a sub-node of the device.
> +
> +  For more product information please see the links below:
> +    https://www.lumissil.com/assets/pdf/core/IS31FL3236_DS.pdf
> +    https://www.lumissil.com/assets/pdf/core/IS31FL3236A_DS.pdf
> +    https://www.lumissil.com/assets/pdf/core/IS31FL3235_DS.pdf
> +    https://www.lumissil.com/assets/pdf/core/IS31FL3218_DS.pdf
> +    https://www.lumissil.com/assets/pdf/core/IS31FL3216_DS.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - issi,is31fl3236
> +      - issi,is31fl3236a
> +      - issi,is31fl3235
> +      - issi,is31fl3218
> +      - issi,is31fl3216
> +      - si-en,sn3218
> +      - si-en,sn3216
> +
> +  reg:
> +    maxItems: 1
> +
> +  '#address-cells':
> +    const: 1
> +
> +  "#size-cells":

Keep consistent quotes, either " or '. You made different choice for the
same properties even...

> +    const: 0
> +
> +patternProperties:
> +  "^led@[1-9a-f]+$":

Pattern does not match entirely the reg constraints. 36 is 0x24.


Best regards,
Krzysztof