linux-kernel - Re: [PATCH 04/19] gpio: wcove: use new GPIO line value setter callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VckSCyDiAtP+q8nGGiJBuMFi3Nke7Puh0SE9nBX4vUX+w@mail.gmail.com>
Date: Wed, 9 Jul 2025 11:32:40 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Linus Walleij <linus.walleij@...aro.org>, 
	Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>, 
	Andy Shevchenko <andy@...nel.org>, Shubhrajyoti Datta <shubhrajyoti.datta@....com>, 
	Srinivas Neeli <srinivas.neeli@....com>, Michal Simek <michal.simek@....com>, 
	Nandor Han <nandor.han@...com>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, patches@...nsource.cirrus.com, 
	linux-arm-kernel@...ts.infradead.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 04/19] gpio: wcove: use new GPIO line value setter callbacks

On Wed, Jul 9, 2025 at 9:42 AM Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>
> struct gpio_chip now has callbacks for setting line values that return
> an integer, allowing to indicate failures. Convert the driver to using
> them.

...

>         if (value)
> -               regmap_set_bits(wg->regmap, reg, 1);
> -       else
> -               regmap_clear_bits(wg->regmap, reg, 1);
> +               return regmap_set_bits(wg->regmap, reg, 1);
> +
> +       return regmap_clear_bits(wg->regmap, reg, 1);

return regmap_assign_bits(...);

Otherwise LGTM,
Reviewed-by: Andy Shevchenko <andy@...nel.org>

-- 
With Best Regards,
Andy Shevchenko