linux-kernel - Re: [PATCH 04/19] gpio: wcove: use new GPIO line value setter callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aG4rVW5m6HSnSJnv@smile.fi.intel.com>
Date: Wed, 9 Jul 2025 11:41:57 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Bartosz Golaszewski <brgl@...ev.pl>,
	Linus Walleij <linus.walleij@...aro.org>,
	Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>,
	Andy Shevchenko <andy@...nel.org>,
	Shubhrajyoti Datta <shubhrajyoti.datta@....com>,
	Srinivas Neeli <srinivas.neeli@....com>,
	Michal Simek <michal.simek@....com>, Nandor Han <nandor.han@...com>,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
	patches@...nsource.cirrus.com, linux-arm-kernel@...ts.infradead.org,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 04/19] gpio: wcove: use new GPIO line value setter
 callbacks

On Wed, Jul 09, 2025 at 11:32:40AM +0300, Andy Shevchenko wrote:
> On Wed, Jul 9, 2025 at 9:42 AM Bartosz Golaszewski <brgl@...ev.pl> wrote:

...

> >         if (value)
> > -               regmap_set_bits(wg->regmap, reg, 1);
> > -       else
> > -               regmap_clear_bits(wg->regmap, reg, 1);
> > +               return regmap_set_bits(wg->regmap, reg, 1);
> > +
> > +       return regmap_clear_bits(wg->regmap, reg, 1);
> 
> return regmap_assign_bits(...);

Btw, since you are doing sometimes two patches, it might worth to have
a prerequisite that changes set/clear to assign and then your patch will
be cleaner.

> Otherwise LGTM,
> Reviewed-by: Andy Shevchenko <andy@...nel.org>

-- 
With Best Regards,
Andy Shevchenko