linux-kernel - Re: [PATCH v2 2/4] ASoC: dt-bindings: Add schema for FS2104/5S audio amplifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250709-invisible-frigatebird-of-felicity-7e87c4@krzk-bin>
Date: Wed, 9 Jul 2025 12:40:33 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Nick Li <nick.li@...rsemi.com>
Cc: lgirdwood@...il.com, broonie@...nel.org, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, perex@...ex.cz, tiwai@...e.com, 
	xiaoming.yang@...rsemi.com, danyang.zheng@...rsemi.com, like.xy@...mail.com, 
	linux-sound@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/4] ASoC: dt-bindings: Add schema for FS2104/5S audio
 amplifiers

On Tue, Jul 08, 2025 at 07:28:59PM +0800, Nick Li wrote:
> +description:
> +  The FS2104 is a 15W Inductor-Less, Stereo, Closed-Loop,
> +  Digital Input Class-D Power Amplifier with Enhanced Signal Processing.
> +  The FS2105S is a 30W Inductor-Less, Stereo, Closed-Loop,
> +  Digital Input Class-D Power Amplifier with Enhanced Signal Processing.
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - foursemi,fs2104
> +          - const: foursemi,fs2105s
> +      - enum:
> +          - foursemi,fs2105s
> +
> +  reg:
> +    maxItems: 1
> +    description:
> +      I2C address of the device. Refer to datasheet for possible values

Now the description is entirely redundant, brings no value. Drop.

> +
> +  clocks:
> +    description: The clock of I2S BCLK

This was different... Previous code was correct, this is not correct.
And nothing in changelog explains this. Do not make random changes after
review.

> +
> +  clock-names:
> +    items:
> +      - const: bclk
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  '#sound-dai-cells':
> +    const: 0
> +
> +  pvdd-supply:
> +    description:
> +      Regulator for power supply(PVDD in datasheet).
> +
> +  dvdd-supply:
> +    description:
> +      Regulator for digital supply(DVDD in datasheet).
> +
> +  reset-gpios:
> +    maxItems: 1
> +    description:
> +      It's the SDZ pin in datasheet, the pin is active low,
> +      it will power down and reset the chip to shut down state.
> +
> +  firmware-name:
> +    maxItems: 1
> +    description: |
> +      The firmware(*.bin) contains:
> +      a. Register initialization settings
> +      b. DSP effect parameters
> +      c. Multi-scene sound effect configurations(optional)
> +      It's gernerated by FourSemi's tuning tool.
> +
> +required:
> +  - compatible
> +  - reg
> +  - reset-gpios
> +  - firmware-name
> +  - '#sound-dai-cells'

Keep the same order as in list of properties. OTOH, missing supplies.

> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +unevaluatedProperties: false

Best regards,
Krzysztof