lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87tt3kw26n.wl-tiwai@suse.de>
Date: Thu, 10 Jul 2025 16:28:00 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Ahelenia Ziemiańska
 <nabijaczleweli@...ijaczleweli.xyz>
Cc: Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ALSA: emu10k1: fix "for/take a while" typos

On Thu, 03 Jul 2025 20:21:29 +0200,
Ahelenia Ziemiańska wrote:
> 
> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@...ijaczleweli.xyz>
> ---
> v1: https://lore.kernel.org/lkml/h2ieddqja5jfrnuh3mvlxt6njrvp352t5rfzp2cvnrufop6tch@tarta.nabijaczleweli.xyz/t/#u

Well, "awhile" is a proper word, AFAIK.


thanks,

Takashi

> 
>  sound/pci/emu10k1/emu10k1_main.c | 2 +-
>  sound/pci/emu10k1/emupcm.c       | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/pci/emu10k1/emu10k1_main.c b/sound/pci/emu10k1/emu10k1_main.c
> index bbe252b8916c..6050201851b1 100644
> --- a/sound/pci/emu10k1/emu10k1_main.c
> +++ b/sound/pci/emu10k1/emu10k1_main.c
> @@ -606,7 +606,7 @@ static int snd_emu10k1_ecard_init(struct snd_emu10k1 *emu)
>  	/* Step 2: Calibrate the ADC and DAC */
>  	snd_emu10k1_ecard_write(emu, EC_DACCAL | EC_LEDN | EC_TRIM_CSN);
>  
> -	/* Step 3: Wait for awhile;   XXX We can't get away with this
> +	/* Step 3: Wait for a while;   XXX We can't get away with this
>  	 * under a real operating system; we'll need to block and wait that
>  	 * way. */
>  	snd_emu10k1_wait(emu, 48000);
> diff --git a/sound/pci/emu10k1/emupcm.c b/sound/pci/emu10k1/emupcm.c
> index 1bf6e3d652f8..ca4b03317539 100644
> --- a/sound/pci/emu10k1/emupcm.c
> +++ b/sound/pci/emu10k1/emupcm.c
> @@ -991,7 +991,7 @@ static snd_pcm_uframes_t snd_emu10k1_capture_pointer(struct snd_pcm_substream *s
>  	if (!epcm->running)
>  		return 0;
>  	if (epcm->first_ptr) {
> -		udelay(50);	/* hack, it takes awhile until capture is started */
> +		udelay(50);	/* hack, it takes a while until capture is started */
>  		epcm->first_ptr = 0;
>  	}
>  	ptr = snd_emu10k1_ptr_read(emu, epcm->capture_idx_reg, 0) & 0x0000ffff;
> -- 
> 2.39.5
> Verifying...

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ