linux-kernel - Re: [PATCH v3 1/2] dt-bindings: media: i2c: Add ov2735 sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250710210532.GE22436@pendragon.ideasonboard.com>
Date: Fri, 11 Jul 2025 00:05:32 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>,
	sakari.ailus@...ux.intel.com, krzk+dt@...nel.org,
	kieran.bingham@...asonboard.com, dave.stevenson@...pberrypi.com,
	pratap.nirujogi@....com, tarang.raval@...iconsignals.io,
	Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	Hans Verkuil <hverkuil@...all.nl>,
	Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
	Ricardo Ribalda <ribalda@...omium.org>,
	André Apitzsch <git@...tzsch.eu>,
	Arnd Bergmann <arnd@...db.de>,
	Dongcheng Yan <dongcheng.yan@...el.com>,
	Jingjing Xiong <jingjing.xiong@...el.com>,
	Matthias Fend <matthias.fend@...end.at>,
	Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
	Sylvain Petinot <sylvain.petinot@...s.st.com>,
	Heimir Thor Sverrisson <heimir.sverrisson@...il.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Hans de Goede <hansg@...nel.org>, linux-media@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: media: i2c: Add ov2735 sensor

On Thu, Jul 10, 2025 at 03:35:51PM +0200, Krzysztof Kozlowski wrote:
> On 10/07/2025 15:10, Hardevsinh Palaniya wrote:
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +  - avdd-supply
> > +  - dovdd-supply
> > +  - dvdd-supply
> > +  - port
> 
> Now  I looked at your driver and the code clearly says that GPIOs are
> not optional.
> 
> You really need to sync the binding in the driver. They cannot define
> completely different ABI.

I couldn't have said it in a clearer way.

For the GPIOs, I recommend making them optional in the driver, as GPIOs
are not always connected in all designs (unless of course we're dealing
with a GPIO whose control from the SoC is absolutely mandatory to make
the device work at all, but that doesn't seem to be the case here).

-- 
Regards,

Laurent Pinchart