| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250710210846.GF22436@pendragon.ideasonboard.com>
Date: Fri, 11 Jul 2025 00:08:46 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Rob Herring <robh@...nel.org>
Cc: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>,
sakari.ailus@...ux.intel.com, krzk+dt@...nel.org,
kieran.bingham@...asonboard.com, dave.stevenson@...pberrypi.com,
pratap.nirujogi@....com, tarang.raval@...iconsignals.io,
Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Hans Verkuil <hverkuil@...all.nl>,
Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
Ricardo Ribalda <ribalda@...omium.org>,
André Apitzsch <git@...tzsch.eu>,
Arnd Bergmann <arnd@...db.de>,
Dongcheng Yan <dongcheng.yan@...el.com>,
Jingjing Xiong <jingjing.xiong@...el.com>,
Matthias Fend <matthias.fend@...end.at>,
Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
Sylvain Petinot <sylvain.petinot@...s.st.com>,
Heimir Thor Sverrisson <heimir.sverrisson@...il.com>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Hans de Goede <hansg@...nel.org>, linux-media@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: media: i2c: Add ov2735 sensor
On Thu, Jul 10, 2025 at 01:33:56PM -0500, Rob Herring wrote:
> On Thu, Jul 10, 2025 at 06:40:58PM +0530, Hardevsinh Palaniya wrote:
> > From: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>
> >
> > Add bindings for Omnivision OV2735 sensor.
> >
> > Signed-off-by: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>
> > Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>
> > ---
> > .../bindings/media/i2c/ovti,ov2735.yaml | 115 ++++++++++++++++++
> > 1 file changed, 115 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml
> > new file mode 100644
> > index 000000000000..d9d01db88844
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml
> > @@ -0,0 +1,115 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/i2c/ovti,ov2735.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: OmniVision OV2735 Image Sensor
> > +
> > +maintainers:
> > + - Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>
> > +
> > +description: |
>
> Don't need '|' if no formatting to preserve.
>
> > + The OmniVision OV2735 is a 2MP (1920x1080) color CMOS image sensor controlled
> > + through an I2C-compatible SCCB bus. it outputs RAW10 format and uses a 1/2.7"
> > + optical format.
> > +
> > +properties:
> > + compatible:
> > + const: ovti,ov2735
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + items:
> > + - description: XVCLK clock
> > +
> > + clock-names:
> > + items:
> > + - const: xvclk
> > +
> > + avdd-supply:
> > + description: Analog Domain Power Supply
> > +
> > + dovdd-supply:
> > + description: I/O Domain Power Supply
> > +
> > + dvdd-supply:
> > + description: Digital Domain Power Supply
> > +
> > + reset-gpios:
> > + maxItems: 1
> > + description: Reset Pin GPIO Control (active low)
> > +
> > + enable-gpios:
> > + maxItems: 1
> > + description: |
>
> Same here.
>
> > + Active-low enable pin. Labeled as 'PWDN' in the datasheet, but acts as
> > + an enable signal. During power rail ramp-up, the device remains powered
> > + down. Once power rails are stable, pulling this pin low powers on the
> > + device.
> > +
> > + port:
> > + description: MIPI CSI-2 transmitter port
> > + $ref: /schemas/graph.yaml#/$defs/port-base
> > + additionalProperties: false
> > +
> > + properties:
> > + endpoint:
> > + $ref: /schemas/media/video-interfaces.yaml#
> > + unevaluatedProperties: false
> > +
> > + properties:
> > + data-lanes:
> > + items:
> > + - const: 1
> > + - const: 2
> > +
> > + required:
> > + - data-lanes
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > + - avdd-supply
> > + - dovdd-supply
> > + - dvdd-supply
> > + - port
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/clock/rk3399-cru.h>
Unused.
> > + #include <dt-bindings/gpio/gpio.h>
> > +
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + camera-sensor@3c {
> > + compatible = "ovti,ov2735";
> > + reg = <0x3c>;
> > + clocks = <&ov2735_clk>;
> > +
> > + assigned-clocks = <&ov2735_clk>;
> > + assigned-clock-parents = <&ov2735_clk_parent>;
> > + assigned-clock-rates = <24000000>;
I think you can drop those three properties from the example, they don't
add much value. Or you could switch to a clock generated by the SoC
(an RK3399 based on the #include above), in which case assigning the
rate makes sense.
> > +
> > + avdd-supply = <&ov2735_avdd>;
> > + dovdd-supply = <&ov2735_dovdd>;
> > + dvdd-supply = <&ov2735_dvdd>;
> > +
> > + reset-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>;
> > + enable-gpios = <&gpio2 11 GPIO_ACTIVE_LOW>;
> > +
> > + port {
> > + cam_out: endpoint {
> > + remote-endpoint = <&mipi_in_cam>;
> > + data-lanes = <1 2>;
> > + };
> > + };
> > + };
> > + };
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists