linux-kernel - Re: [PATCH 3/6] dt-bindings: reset: add BCM63268 ephy reset definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250710215454.GA4033782-robh@kernel.org>
Date: Thu, 10 Jul 2025 16:54:54 -0500
From: Rob Herring <robh@...nel.org>
To: Kyle Hendry <kylehendrydev@...il.com>
Cc: Philipp Zabel <p.zabel@...gutronix.de>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Fernández Rojas <noltari@...il.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] dt-bindings: reset: add BCM63268 ephy reset
 definitions

On Tue, Jul 08, 2025 at 07:47:27PM -0700, Kyle Hendry wrote:
> Add definitions for resets in the ephy control register.
> 
> Signed-off-by: Kyle Hendry <kylehendrydev@...il.com>
> ---
>  include/dt-bindings/reset/bcm63268-reset.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/dt-bindings/reset/bcm63268-reset.h b/include/dt-bindings/reset/bcm63268-reset.h
> index d87a7882782a..676a62c9777b 100644
> --- a/include/dt-bindings/reset/bcm63268-reset.h
> +++ b/include/dt-bindings/reset/bcm63268-reset.h
> @@ -27,4 +27,8 @@
>  #define BCM63268_TRST_HW	30
>  #define BCM63268_TRST_POR	31
>  
> +#define BCM63268_RST_EPHY1 0
> +#define BCM63268_RST_EPHY2 1
> +#define BCM63268_RST_EPHY3 2

These are kind of pointless IMO. The provider is only for the EPHYs and 
your number is just index+1.

Rob