linux-kernel - Re: [PATCH v4] i2c: busses: Use min() to improve code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250711154717.00000319@huawei.com>
Date: Fri, 11 Jul 2025 15:47:17 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Andi Shyti <andi.shyti@...nel.org>
CC: Qianfeng Rong <rongqianfeng@...o.com>, <wsa+renesas@...g-engineering.com>,
	Patrice Chotard <patrice.chotard@...s.st.com>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-i2c@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] i2c: busses: Use min() to improve code

On Thu, 10 Jul 2025 22:42:26 +0200
Andi Shyti <andi.shyti@...nel.org> wrote:

> Hi Qianfeng,
> 
> On Wed, Jul 09, 2025 at 12:23:46PM +0800, Qianfeng Rong wrote:
> > Use min() to reduce the code and improve its readability.
> > 
> > The type of the max parameter in the st_i2c_rd_fill_tx_fifo()
> > was changed from int to u32, because the max parameter passed
> > in is always greater than 0.
> > 
> > Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
> > Reviewed-by: Patrice Chotard <patrice.chotard@...s.st.com>
> > Suggested-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>  
> 
> The 'Suggested-by' tag implies that the patch was suggested by
> Jonathan, which is not the case here. Jonathan reviewed the patch
> and proposed improvements, but the patch itself comes from you.
> 
> For this reason, I will remove the 'Suggested-by' tag. If
> Jonathan wants to add his Acked-by or Reviewed-by, I will gladly
> include it.

Trivial enough that I don't care ;)  Was a drive by review at
best.

Thanks for asking though.

J

> 
> Thanks, Jonathan, for the helpful reviews, and thanks to Qianfeng
> for promptly following up on the feedback.
> 
> Merged to i2c/i2c-host.
> 
> Thanks,
> Andi
>