linux-kernel - Re: [PATCH] [v2] block: fix FS_IOC_GETLBMD_CAP parsing in blkdev_common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e3450519-dbeb-4741-9772-7e33462155f9@kernel.dk>
Date: Fri, 11 Jul 2025 08:47:31 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Arnd Bergmann <arnd@...nel.org>, Anuj Gupta <anuj20.g@...sung.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 Kanchan Joshi <joshi.k@...sung.com>, Christian Brauner <brauner@...nel.org>
Cc: Christoph Hellwig <hch@...radead.org>, Arnd Bergmann <arnd@...db.de>,
 Naresh Kamboju <naresh.kamboju@...aro.org>,
 Anders Roxell <anders.roxell@...aro.org>, Keith Busch <kbusch@...nel.org>,
 Caleb Sander Mateos <csander@...estorage.com>,
 Pavel Begunkov <asml.silence@...il.com>,
 Alexey Dobriyan <adobriyan@...il.com>, "Darrick J. Wong"
 <djwong@...nel.org>, linux-block@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] block: fix FS_IOC_GETLBMD_CAP parsing in
 blkdev_common_ioctl()

On 7/11/25 2:46 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Anders and Naresh found that the addition of the FS_IOC_GETLBMD_CAP
> handling in the blockdev ioctl handler breaks all ioctls with
> _IOC_NR==2, as the new command is not added to the switch but only
> a few of the command bits are check.
> 
> Move the check into the blk_get_meta_cap() function itself and make
> it return -ENOIOCTLCMD for any unsupported command code, including
> those with a smaller size that previously returned -EINVAL.
> 
> For consistency this also drops the check for NULL 'arg' that
> is really useless, as any invalid pointer should return -EFAULT.
> 
> Fixes: 9eb22f7fedfc ("fs: add ioctl to query metadata and protection info capabilities")

Since this isn't from my tree:

Reviewed-by: Jens Axboe <axboe@...nel.dk>

-- 
Jens Axboe