linux-kernel - Re: [PATCH] drm/nouveau: check ioctl command codes better

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0a66b263-0d5d-4758-b6b5-fc3905612d10@app.fastmail.com>
Date: Fri, 11 Jul 2025 20:01:40 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Danilo Krummrich" <dakr@...nel.org>, "Arnd Bergmann" <arnd@...nel.org>
Cc: "Lyude Paul" <lyude@...hat.com>, "Dave Airlie" <airlied@...il.com>,
 "Simona Vetter" <simona@...ll.ch>, "bskeggs@...hat.com" <bskeggs@...hat.com>,
 "Ben Skeggs" <bskeggs@...dia.com>, "Timur Tabi" <ttabi@...dia.com>,
 "Dave Airlie" <airlied@...hat.com>,
 "Thomas Zimmermann" <tzimmermann@...e.de>, dri-devel@...ts.freedesktop.org,
 "nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/nouveau: check ioctl command codes better

On Fri, Jul 11, 2025, at 19:41, Danilo Krummrich wrote:
> On Fri Jul 11, 2025 at 9:24 AM CEST, Arnd Bergmann wrote:
>> diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
>> index 1527b801f013..506eeb44f0d4 100644
>> --- a/drivers/gpu/drm/nouveau/nouveau_drm.c
>> +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
>> @@ -1284,6 +1284,9 @@ nouveau_ioctls[] = {
>>  	DRM_IOCTL_DEF_DRV(NOUVEAU_EXEC, nouveau_exec_ioctl_exec, DRM_RENDER_ALLOW),
>>  };
>>  
>> +#define DRM_IOCTL_NOUVEAU_NVIV _IOC(_IOC_READ|_IOC_WRITE, DRM_IOCTL_BASE, \
>> +				    DRM_COMMAND_BASE + DRM_NOUVEAU_NVIF, 0)
>
> Is there any intention behind NVIV vs NVIF? Indicator that size is not
> considered?

No, just a typo, my mistake.

      Arnd