linux-kernel - Re: [PATCH] drm/nouveau: check ioctl command codes better

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DB9FBT4H5FOZ.14JZJCXMEIYU1@kernel.org>
Date: Fri, 11 Jul 2025 20:06:14 +0200
From: "Danilo Krummrich" <dakr@...nel.org>
To: "Arnd Bergmann" <arnd@...nel.org>
Cc: "Lyude Paul" <lyude@...hat.com>, "David Airlie" <airlied@...il.com>,
 "Simona Vetter" <simona@...ll.ch>, "Ben Skeggs" <bskeggs@...hat.com>, "Arnd
 Bergmann" <arnd@...db.de>, "Ben Skeggs" <bskeggs@...dia.com>, "Timur Tabi"
 <ttabi@...dia.com>, "Dave Airlie" <airlied@...hat.com>, "Thomas Zimmermann"
 <tzimmermann@...e.de>, <dri-devel@...ts.freedesktop.org>,
 <nouveau@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/nouveau: check ioctl command codes better

On Fri Jul 11, 2025 at 9:24 AM CEST, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> nouveau_drm_ioctl() only checks the _IOC_NR() bits in the DRM_NOUVEAU_NVIF
> command, but ignores the type and direction bits, so any command with
> '7' in the low eight bits gets passed into nouveau_abi16_ioctl() instead
> of drm_ioctl().
>
> Check for all the bits except the size that is handled inside of the handler.
>
> Fixes: 27111a23d01c ("drm/nouveau: expose the full object/event interfaces to userspace")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied to drm-misc-fixes, thanks!

  [ Fix up two checkpatch warnings and a typo. - Danilo ]