linux-kernel - Re: [PATCH] rust: time: Pass correct timer mode ID to hrtimer_start_range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ecuni5nm.fsf@kernel.org>
Date: Fri, 11 Jul 2025 08:49:01 +0200
From: Andreas Hindborg <a.hindborg@...nel.org>
To: "FUJITA Tomonori" <fujita.tomonori@...il.com>
Cc: <lyude@...hat.com>,  <rust-for-linux@...r.kernel.org>,
  <boqun.feng@...il.com>,  <frederic@...nel.org>,  <tglx@...utronix.de>,
  <anna-maria@...utronix.de>,  <jstultz@...gle.com>,  <sboyd@...nel.org>,
  <ojeda@...nel.org>,  <alex.gaynor@...il.com>,  <gary@...yguo.net>,
  <bjorn3_gh@...tonmail.com>,  <lossin@...nel.org>,
  <aliceryhl@...gle.com>,  <tmgross@...ch.edu>,  <dakr@...nel.org>,
  <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rust: time: Pass correct timer mode ID to
 hrtimer_start_range_ns

"FUJITA Tomonori" <fujita.tomonori@...il.com> writes:

> On Fri, 11 Jul 2025 08:18:37 +0200
> Andreas Hindborg <a.hindborg@...nel.org> wrote:
>
>> "Lyude Paul" <lyude@...hat.com> writes:
>>
>>> While rebasing rvkms I noticed that timers I was setting seemed to have
>>> pretty random timer values that amounted slightly over 2x the time value I
>>> set each time. After a lot of debugging, I finally managed to figure out
>>> why: it seems that since we moved to Instant and Delta, we mistakenly
>>> began passing the clocksource ID to hrtimer_start_range_ns, when we should
>>> be passing the timer mode instead. Presumably, this works fine for simple
>>> relative timers - but immediately breaks on other types of timers.
>>>
>>> So, fix this by passing the ID for the timer mode instead.
>>>
>>> Signed-off-by: Lyude Paul <lyude@...hat.com>
>>> Cc: FUJITA Tomonori <fujita.tomonori@...il.com>
>>> Fixes: fcc1dd8c8656 ("rust: time: Make HasHrTimer generic over HrTimerMode")
>>
>> Wow, thanks! Miguel, can you take this through rust-fixes?
>
> I think that this patch fixes the commit in timekeeping-next.
>
> `fcc1dd8c8656` doesn't match to the commit in the current
> timekeeping-next (this patch might have been made against the tree
> before it was rebased).

Maybe Miguel can put the correct hash when he applies the patch.


Best regards,
Andreas Hindborg