linux-kernel - Re: [PATCH] kunit: Enable PCI on UML without triggering WARN()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d88d15047569b57c7e7cd751670f56ffb4d5c1a8.camel@sipsolutions.net>
Date: Fri, 11 Jul 2025 08:48:45 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>, 
 Brendan Higgins <brendan.higgins@...ux.dev>, David Gow
 <davidgow@...gle.com>, Rae Moar <rmoar@...gle.com>,  Richard Weinberger	
 <richard@....at>, Anton Ivanov <anton.ivanov@...bridgegreys.com>
Cc: linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com, 
	linux-kernel@...r.kernel.org, linux-um@...ts.infradead.org
Subject: Re: [PATCH] kunit: Enable PCI on UML without triggering WARN()

On Fri, 2025-06-27 at 17:21 +0200, Thomas Weißschuh wrote:
> Various KUnit tests require PCI infrastructure to work.
> All normal platforms enable PCI by default, but UML does not.
> Enabling PCI from .kunitconfig files is problematic as it would not be
> portable. So in commit 6fc3a8636a7b ("kunit: tool: Enable virtio/PCI by default on UML")
> PCI was enabled by way of CONFIG_UML_PCI_OVER_VIRTIO=y.
> However CONFIG_UML_PCI_OVER_VIRTIO requires additional configuration of
> CONFIG_UML_PCI_OVER_VIRTIO_DEVICE_ID or will otherwise trigger a WARN() in
> virtio_pcidev_init(). However there is no one correct value for
> UML_PCI_OVER_VIRTIO_DEVICE_ID which could be used by default.
> 
> This warning is confusing when debugging test failures.
> 
> On the other hand, the functionality of CONFIG_UML_PCI_OVER_VIRTIO is not
> used at all, given that it is completely non-functional as indicated by
> the WARN() in question. Instead it is only used as a way to enable
> CONFIG_UML_PCI which itself is not directly configurable.
> 
> Instead of going through CONFIG_UML_PCI_OVER_VIRTIO, introduce a custom
> configuration option which enables CONFIG_UML_PCI without triggering
> warnings or building dead code.

Alright, so looked like Thomas wanted this to not be merged via the UML
tree, which does make sense, so I've dropped it.

For the kunit tree then you can add:

Reviewed-by: Johannes Berg <johannes@...solutions.net>

johannes