linux-kernel - Re: [PATCH] iomap: avoid unnecessary ifs_set_range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aHDAykGCnDXeUZD1@infradead.org>
Date: Fri, 11 Jul 2025 00:44:10 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Jinliang Zheng <alexjlzheng@...il.com>
Cc: hch@...radead.org, alexjlzheng@...cent.com, brauner@...nel.org,
	djwong@...nel.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	linux-xfs@...r.kernel.org
Subject: Re: [PATCH] iomap: avoid unnecessary ifs_set_range_uptodate() with
 locks

On Wed, Jul 09, 2025 at 11:30:42AM +0800, Jinliang Zheng wrote:
> In addition, what I want to say is that once folio_test_uptodate() is
> true, all bits in ifs->state are in the uptodate state. So there is no
> need to acquire the lock and set it again. This repeated setting happens
> in __iomap_write_end().

Yes, that seems fine.  Can you update the commit message with some of
the insights from this discussion, and with that the patch should be
fine.