linux-kernel - Re: [PATCH] soc: hisilicon: kunpeng_hccs: Fix incorrect log information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250711113816.00003403@huawei.com>
Date: Fri, 11 Jul 2025 11:38:16 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Huisong Li <lihuisong@...wei.com>, <linuxarm@...wei.com>
CC: <xuwei5@...wei.com>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <jonathan.cameron@...wei.com>,
	<zhanjie9@...ilicon.com>
Subject: Re: [PATCH] soc: hisilicon: kunpeng_hccs: Fix incorrect log
 information

On Fri, 11 Jul 2025 14:37:06 +0800
Huisong Li <lihuisong@...wei.com> wrote:

> The hccs_get_all_spec_port_idle_sta() will tell user which port
> is busy when firmware doesn't allow to decrease HCCS lane number.
> However, the current log prints the index of die and port instead
> of the hardware ID user perceived.
> 
> Signed-off-by: Huisong Li <lihuisong@...wei.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@...wei.com>

Maybe adding an example of a wrong print and how it is fixed to this
patch description would make the problem even more obvious?
Not worth respin for that though!

> ---
>  drivers/soc/hisilicon/kunpeng_hccs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/hisilicon/kunpeng_hccs.c b/drivers/soc/hisilicon/kunpeng_hccs.c
> index 7fc353732d55..65ff45fdcac7 100644
> --- a/drivers/soc/hisilicon/kunpeng_hccs.c
> +++ b/drivers/soc/hisilicon/kunpeng_hccs.c
> @@ -1295,11 +1295,11 @@ static int hccs_get_all_spec_port_idle_sta(struct hccs_dev *hdev, u8 port_type,
>  				if (ret) {
>  					dev_err(hdev->dev,
>  						"hccs%u on chip%u/die%u get idle status failed, ret = %d.\n",
> -						k, i, j, ret);
> +						port->port_id, chip->chip_id, die->die_id, ret);
>  					return ret;
>  				} else if (idle == 0) {
>  					dev_info(hdev->dev, "hccs%u on chip%u/die%u is busy.\n",
> -						k, i, j);
> +						 port->port_id, chip->chip_id, die->die_id);
>  					return 0;
>  				}
>  			}