linux-kernel - Re: [PATCH v9 1/3] staging: media: atomisp: fix indentation in aa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aHEB70JWm1sotEXI@smile.fi.intel.com>
Date: Fri, 11 Jul 2025 15:22:07 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: LiangCheng Wang <zaq14760@...il.com>
Cc: Andy Shevchenko <andy@...nel.org>, Hans de Goede <hansg@...nel.org>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-staging@...ts.linux.dev
Subject: Re: [PATCH v9 1/3] staging: media: atomisp: fix indentation in aa

On Fri, Jul 11, 2025 at 07:54:36PM +0800, LiangCheng Wang wrote:
> This patch fixes tab/space indentation issues in aa

The Submitting Patches insists to use imperative mode.

> following kernel coding style guidelines.

No, currently the code does something different, you forgot to update
the commit message. Something like

"""
Move a standalone kernel-doc comment of the 'strength' field of
the struct ia_css_aa_config to the whole-structure one.
"""

...

> Link: https://lore.kernel.org/all/CAHp75Vfc7QsENHsaYMKau_4DU3-LmW2XaUxd=oHqTS3F3R85eg@mail.gmail.com/
> Link: https://lore.kernel.org/all/e201c4b0-4fcc-4d98-9d76-0e9c41dc4d9f@kernel.org/

Unneeded Link tags. It actually doesn't matter when and how it was suggested,
the relevant people are automatically added to Cc list.

The rule of thumb is that the person who suggested the change (in terms of
Suggested-by tag) should also provide at least Acked-by (or Reviewed-by).
It can be optional if that person is the same as the committer of the changes
(depends on them and respective maintainers).

> ---

Code wise LGTM.

-- 
With Best Regards,
Andy Shevchenko