linux-kernel - Re: [PATCH v9 2/3] staging: media: atomisp: fix indentation in anr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aHECrvSQCicV5nP5@smile.fi.intel.com>
Date: Fri, 11 Jul 2025 15:25:18 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: LiangCheng Wang <zaq14760@...il.com>
Cc: Andy Shevchenko <andy@...nel.org>, Hans de Goede <hansg@...nel.org>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-staging@...ts.linux.dev
Subject: Re: [PATCH v9 2/3] staging: media: atomisp: fix indentation in anr

On Fri, Jul 11, 2025 at 07:54:37PM +0800, LiangCheng Wang wrote:
> This patch fixes tab/space indentation issues in anr
> following kernel coding style guidelines.
> 
> No functional logic changes were made.

Same comments about Link tags and suggestions in general.

...

>  		0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
>  		0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4

Side note, would be nice to add a trailing comma here.
I think it's okay to do in this patch as this is not
enough for a separate change and the driver in staging,
the rules are slightly relaxed on it.

>  	},
> -	{10, 20, 30}
> +	{ 10, 20, 30 },
>  };

-- 
With Best Regards,
Andy Shevchenko