linux-kernel - Re: [PATCH] dt-bindings: mmc: ti,da830-mmc: convert text based binding to json schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <93f7f1b7-8c04-4d0e-9e41-6127651bdca4@kernel.org>
Date: Sat, 12 Jul 2025 10:29:42 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Charan Pedumuru <charan.pedumuru@...il.com>,
 Ulf Hansson <ulf.hansson@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: ti,da830-mmc: convert text based
 binding to json schema

On 12/07/2025 10:22, Charan Pedumuru wrote:
>>> +
>>> +allOf:
>>> +  - $ref: mmc-controller.yaml
>>> +
>>> +maintainers:
>>> +  - Rob Herring <robh@...nel.org>
>>
>> No, I really doubt Rob cares about this hardware.
> 
> I will remove Rob from maintainers and add Ulf under the maintainers.

This should be someone responsible for this hardware, not subsystem
maintainer.

> 
>>
>>> +
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - ti,da830-mmc
>>> +      - ti,dm355-mmc
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  clocks:
>>> +    maxItems: 1
>>> +
>>> +  interrupts:
>>> +    maxItems: 2
>>> +
>>
>> This wasn't in original binding. You need to document this in the commit
>> msg. Also, list the items.
> 
> Sure, but what list of items for interrupts?

List as a verb. You need to list them.


Best regards,
Krzysztof