[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <048d1b86-1575-4e31-b5cf-b6f72b2843fa@gmail.com>
Date: Sun, 7 Sep 2025 12:23:03 +0530
From: Charan Pedumuru <charan.pedumuru@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
Ulf Hansson <ulf.hansson@...aro.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: ti,da830-mmc: convert text based
binding to json schema
On 12-07-2025 13:59, Krzysztof Kozlowski wrote:
> On 12/07/2025 10:22, Charan Pedumuru wrote:
>>>> +
>>>> +allOf:
>>>> + - $ref: mmc-controller.yaml
>>>> +
>>>> +maintainers:
>>>> + - Rob Herring <robh@...nel.org>
>>>
>>> No, I really doubt Rob cares about this hardware.
>>
>> I will remove Rob from maintainers and add Ulf under the maintainers.
>
> This should be someone responsible for this hardware, not subsystem
> maintainer.
Sure, I will search for subsystem maintainer from get_maintainer script.
>
>>
>>>
>>>> +
>>>> +properties:
>>>> + compatible:
>>>> + enum:
>>>> + - ti,da830-mmc
>>>> + - ti,dm355-mmc
>>>> +
>>>> + reg:
>>>> + maxItems: 1
>>>> +
>>>> + clocks:
>>>> + maxItems: 1
>>>> +
>>>> + interrupts:
>>>> + maxItems: 2
>>>> +
>>>
>>> This wasn't in original binding. You need to document this in the commit
>>> msg. Also, list the items.
>>
>> Sure, but what list of items for interrupts?
>
> List as a verb. You need to list them.
I searched for interrupt-names for mmc node in the DTS file, but there isn't any for davinci series.
>
>
> Best regards,
> Krzysztof
--
Best Regards,
Charan.
Powered by blists - more mailing lists