linux-kernel - Re: [PATCH v2] Revert "leds: trigger: netdev: Configure LED blink interval for HW offload"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8979c6a6-f553-4d9a-ad26-9d1d90b11b1c@lunn.ch>
Date: Sat, 12 Jul 2025 18:30:45 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Lee Jones <lee@...nel.org>, Pavel Machek <pavel@...nel.org>,
	Marek Vasut <marek.vasut@...lbox.org>,
	Lukasz Majewski <lukma@...x.de>,
	Christian Marangi <ansuelsmth@...il.com>,
	Heiner Kallweit <hkallweit1@...il.com>, linux-leds@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Revert "leds: trigger: netdev: Configure LED blink
 interval for HW offload"

On Sat, Jul 12, 2025 at 04:39:21PM +0100, Daniel Golle wrote:
> This reverts commit c629c972b310af41e9e072febb6dae9a299edde6.
> 
> While .led_blink_set() would previously put an LED into an unconditional
> permanently blinking state, the offending commit now uses same operation
> to (also?) set the blink timing of the netdev trigger when offloading.
> 
> This breaks many if not all of the existing PHY drivers which offer
> offloading LED operations, as those drivers would just put the LED into
> blinking state after .led_blink_set() has been called.
> 
> Unfortunately the change even made it into stable kernels for unknown
> reasons, so it should be reverted there as well.
> 
> Fixes: c629c972b310a ("leds: trigger: netdev: Configure LED blink interval for HW offload")
> Link: https://lore.kernel.org/linux-leds/c6134e26-2e45-4121-aa15-58aaef327201@lunn.ch/T/#m9d6fe81bbcb273e59f12bbedbd633edd32118387
> Suggested-by: Andrew Lunn <andrew@...n.ch>
> Cc: stable@...r.kernel.org
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>

Thanks for extending the commit message.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew