linux-kernel - Re: (subset) [PATCH v2] Revert "leds: trigger: netdev: Configure LED blink interval for HW offload"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <175284523331.219050.5074159339576881850.b4-ty@kernel.org>
Date: Fri, 18 Jul 2025 14:27:13 +0100
From: Lee Jones <lee@...nel.org>
To: Lee Jones <lee@...nel.org>, Pavel Machek <pavel@...nel.org>, 
 Andrew Lunn <andrew@...n.ch>, Marek Vasut <marek.vasut@...lbox.org>, 
 Lukasz Majewski <lukma@...x.de>, Christian Marangi <ansuelsmth@...il.com>, 
 Heiner Kallweit <hkallweit1@...il.com>, linux-leds@...r.kernel.org, 
 linux-kernel@...r.kernel.org, Daniel Golle <daniel@...rotopia.org>
Subject: Re: (subset) [PATCH v2] Revert "leds: trigger: netdev: Configure
 LED blink interval for HW offload"

On Sat, 12 Jul 2025 16:39:21 +0100, Daniel Golle wrote:
> This reverts commit c629c972b310af41e9e072febb6dae9a299edde6.
> 
> While .led_blink_set() would previously put an LED into an unconditional
> permanently blinking state, the offending commit now uses same operation
> to (also?) set the blink timing of the netdev trigger when offloading.
> 
> This breaks many if not all of the existing PHY drivers which offer
> offloading LED operations, as those drivers would just put the LED into
> blinking state after .led_blink_set() has been called.
> 
> [...]

Applied, thanks!

[1/1] Revert "leds: trigger: netdev: Configure LED blink interval for HW offload"
      commit: 26f732791f2bcab18f59c61915bbe35225f30136

--
Lee Jones [李琼斯]