linux-kernel - Re: [PATCHv3 wireless-next 7/7] dt-bindings: net: wireless: rt2800: add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e435a765-fb91-408f-81dd-01a73fc43b6b@kernel.org>
Date: Sat, 12 Jul 2025 18:53:38 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Stanislaw Gruszka <stf_xl@...pl>
Cc: Rosen Penev <rosenp@...il.com>, linux-wireless@...r.kernel.org,
 Johannes Berg <johannes@...solutions.net>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>,
 "open list:MIPS" <linux-mips@...r.kernel.org>,
 "moderated list:ARM/Mediatek SoC support"
 <linux-arm-kernel@...ts.infradead.org>,
 "moderated list:ARM/Mediatek SoC support"
 <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCHv3 wireless-next 7/7] dt-bindings: net: wireless: rt2800:
 add

On 12/07/2025 12:40, Stanislaw Gruszka wrote:
> Hi Krzysztof,
> 
> On Fri, Jul 11, 2025 at 09:48:49AM +0200, Krzysztof Kozlowski wrote:
>> On Thu, Jul 10, 2025 at 03:40:30PM -0700, Rosen Penev wrote:
>>> On Thu, Jul 10, 2025 at 2:40 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>>>>
>>>> On 10/07/2025 22:08, Rosen Penev wrote:
>>>>> Add device-tree bindings for the RT2800 SOC wifi device found in older
>>>>> Ralink/Mediatek devices.
>>>>>
>>>>> Signed-off-by: Rosen Penev <rosenp@...il.com>
>>>>> ---
>>>>>  .../bindings/net/wireless/ralink,rt2800.yaml  | 47 +++++++++++++++++++
>>>>>  1 file changed, 47 insertions(+)
>>>>>  create mode 100644 Documentation/devicetree/bindings/net/wireless/ralink,rt2800.yaml
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/net/wireless/ralink,rt2800.yaml b/Documentation/devicetree/bindings/net/wireless/ralink,rt2800.yaml
>>>>> new file mode 100644
>>>>> index 000000000000..8c13b25bd8b4
>>>>> --- /dev/null
>>>>> +++ b/Documentation/devicetree/bindings/net/wireless/ralink,rt2800.yaml
>>>>
>>>> Filename should match compatible. You were already changing something
>>>> here...
>>> hrm? that makes no sense. Various drivers have multiple compatible lines.
>>
>> Luckily we do not speak about drivers here. Anyway, follow standard
>> review practices, you don't get special rules.
> 
> Could you please elaborate what you mean ?

Rosen replied in abrasive way, so I am not going to dig this.

> 
> I greped through Documentation/devicetree/bindings/*/*.yaml and plenty

I assume you refer to last 2 years bindings, not something older, right?
It is really poor argument to find old files and use them as example
"they did like that".

> of "compatible:" items do not match the filename. So hard to tell

I did not ask for compatible to match filename.

> what rule you are referencing, as it seems it's not really applied.
Check reviews on the lists. It is pretty standard review. Everyone gets
it for this case here - single device, single compatible.

Best regards,
Krzysztof