linux-kernel - drivers/net/wireless/ath/ath12k/mac.c:9785:2-3: Unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202507132355.ljWuxxjd-lkp@intel.com>
Date: Sun, 13 Jul 2025 23:50:56 +0800
From: kernel test robot <lkp@...el.com>
To: Baochen Qiang <quic_bqiang@...cinc.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Jeff Johnson <jeff.johnson@....qualcomm.com>,
	Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@....qualcomm.com>
Subject: drivers/net/wireless/ath/ath12k/mac.c:9785:2-3: Unneeded semicolon

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   3f31a806a62e44f7498e2d17719c03f816553f11
commit: cccbb9d0dd6ab9e3353066217e9ab5b44bd761d3 wifi: ath12k: add parse of transmit power envelope element
date:   8 weeks ago
config: riscv-randconfig-r063-20250713 (https://download.01.org/0day-ci/archive/20250713/202507132355.ljWuxxjd-lkp@intel.com/config)
compiler: riscv32-linux-gcc (GCC) 13.4.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507132355.ljWuxxjd-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/net/wireless/ath/ath12k/mac.c:9785:2-3: Unneeded semicolon

vim +9785 drivers/net/wireless/ath/ath12k/mac.c

  9754	
  9755	static void ath12k_mac_parse_tx_pwr_env(struct ath12k *ar,
  9756						struct ath12k_link_vif *arvif)
  9757	{
  9758		struct ieee80211_bss_conf *bss_conf = ath12k_mac_get_link_bss_conf(arvif);
  9759		struct ath12k_reg_tpc_power_info *tpc_info = &arvif->reg_tpc_info;
  9760		struct ieee80211_parsed_tpe_eirp *local_non_psd, *reg_non_psd;
  9761		struct ieee80211_parsed_tpe_psd *local_psd, *reg_psd;
  9762		struct ieee80211_parsed_tpe *tpe = &bss_conf->tpe;
  9763		enum wmi_reg_6g_client_type client_type;
  9764		struct ath12k_reg_info *reg_info;
  9765		struct ath12k_base *ab = ar->ab;
  9766		bool psd_valid, non_psd_valid;
  9767		int i;
  9768	
  9769		reg_info = ab->reg_info[ar->pdev_idx];
  9770		client_type = reg_info->client_type;
  9771	
  9772		local_psd = &tpe->psd_local[client_type];
  9773		reg_psd = &tpe->psd_reg_client[client_type];
  9774		local_non_psd = &tpe->max_local[client_type];
  9775		reg_non_psd = &tpe->max_reg_client[client_type];
  9776	
  9777		psd_valid = local_psd->valid | reg_psd->valid;
  9778		non_psd_valid = local_non_psd->valid | reg_non_psd->valid;
  9779	
  9780		if (!psd_valid && !non_psd_valid) {
  9781			ath12k_warn(ab,
  9782				    "no transmit power envelope match client power type %d\n",
  9783				    client_type);
  9784			return;
> 9785		};
  9786	
  9787		if (psd_valid) {
  9788			tpc_info->is_psd_power = true;
  9789	
  9790			tpc_info->num_pwr_levels = max(local_psd->count,
  9791						       reg_psd->count);
  9792			if (tpc_info->num_pwr_levels > ATH12K_NUM_PWR_LEVELS)
  9793				tpc_info->num_pwr_levels = ATH12K_NUM_PWR_LEVELS;
  9794	
  9795			for (i = 0; i < tpc_info->num_pwr_levels; i++) {
  9796				tpc_info->tpe[i] = min(local_psd->power[i],
  9797						       reg_psd->power[i]) / 2;
  9798				ath12k_dbg(ab, ATH12K_DBG_MAC,
  9799					   "TPE PSD power[%d] : %d\n",
  9800					   i, tpc_info->tpe[i]);
  9801			}
  9802		} else {
  9803			tpc_info->is_psd_power = false;
  9804			tpc_info->eirp_power = 0;
  9805	
  9806			tpc_info->num_pwr_levels = max(local_non_psd->count,
  9807						       reg_non_psd->count);
  9808			if (tpc_info->num_pwr_levels > ATH12K_NUM_PWR_LEVELS)
  9809				tpc_info->num_pwr_levels = ATH12K_NUM_PWR_LEVELS;
  9810	
  9811			for (i = 0; i < tpc_info->num_pwr_levels; i++) {
  9812				tpc_info->tpe[i] = min(local_non_psd->power[i],
  9813						       reg_non_psd->power[i]) / 2;
  9814				ath12k_dbg(ab, ATH12K_DBG_MAC,
  9815					   "non PSD power[%d] : %d\n",
  9816					   i, tpc_info->tpe[i]);
  9817			}
  9818		}
  9819	}
  9820	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki