linux-kernel - Re: [PATCH v2 0/2] ARM: BCM5301X: Add support for Buffalo WXR-1750DHP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <175250104141.2052760.5355993543096717369.robh@kernel.org>
Date: Mon, 14 Jul 2025 10:24:32 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Taishi Shimizu <s.taishi14142@...il.com>
Cc: devicetree@...r.kernel.org, 
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, 
 Rafal Milecki <zajec5@...il.com>, Stefan Wahren <wahrenst@....net>, 
 Florian Fainelli <florian.fainelli@...adcom.com>, 
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
 Linus Walleij <linus.walleij@...aro.org>, Hauke Mehrtens <hauke@...ke-m.de>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Conor Dooley <conor+dt@...nel.org>, 
 Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>
Subject: Re: [PATCH v2 0/2] ARM: BCM5301X: Add support for Buffalo
 WXR-1750DHP


On Sun, 13 Jul 2025 16:18:23 +0900, Taishi Shimizu wrote:
> This patch series adds support for the Buffalo WXR-1750DHP router,
> based on the Broadcom BCM4708 SoC.
> 
> Patch 1 updates the device tree bindings documentation to list
> Buffalo WXR-1750DHP as a supported board under BCM4708.
> 
> Patch 2 introduces a device tree source file for the router.
> 
> Changes since v1:
>  - remove `chosen` node and `bootargs` (inherited from bcm4708.dtsi)
>  - replace `label` in LEDs with `color` and `function` properties
>  - change USB LED to use `LED_FUNCTION_USB` and added `trigger-sources`
>  - reorder GPIOs and clean up button node formatting
> 
> Taishi Shimizu (2):
>   dt-bindings: arm: bcm: Add support for Buffalo WXR-1750DHP
>   ARM: dts: BCM5301X: Add support for Buffalo WXR-1750DHP
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> # for patch 1
> 
>  .../bindings/arm/bcm/brcm,bcm4708.yaml        |   1 +
>  arch/arm/boot/dts/broadcom/Makefile           |   1 +
>  .../broadcom/bcm4708-buffalo-wxr-1750dhp.dts  | 138 ++++++++++++++++++
>  3 files changed, 140 insertions(+)
>  create mode 100644 arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dts
> 
> 
> base-commit: 379f604cc3dc2c865dc2b13d81faa166b6df59ec
> --
> 2.43.0
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: using specified base-commit 379f604cc3dc2c865dc2b13d81faa166b6df59ec

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/broadcom/' for 20250713071826.726682-1-s.taishi14142@...il.com:

arch/arm/boot/dts/broadcom/bcm958305k.dtb: pwm@...aa500 (brcm,kona-pwm): compatible:0: 'brcm,kona-pwm' is not one of ['brcm,bcm11351-pwm']
	from schema $id: http://devicetree.org/schemas/pwm/brcm,kona-pwm.yaml#
arch/arm/boot/dts/broadcom/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@...00: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: /axi@...00000: failed to match any schema with compatible: ['brcm,bus-axi']
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: pcie@...00: 'device_type' is a required property
	from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: pcie@...00: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: pcie@...00: 'device_type' is a required property
	from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: pcie@...00: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: pcie@...00: 'device_type' is a required property
	from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: pcie@...00: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: ethernet-switch@...07000 (brcm,bcm53011-srab): ports:port@5: 'phy-mode' is a required property
	from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: ethernet-switch@...07000 (brcm,bcm53011-srab): ports:port@5: 'oneOf' conditional failed, one must be fixed:
	'fixed-link' is a required property
	'phy-handle' is a required property
	'managed' is a required property
	from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: ethernet-switch@...07000 (brcm,bcm53011-srab): ports:port@7: 'phy-mode' is a required property
	from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: ethernet-switch@...07000 (brcm,bcm53011-srab): ports:port@7: 'oneOf' conditional failed, one must be fixed:
	'fixed-link' is a required property
	'phy-handle' is a required property
	'managed' is a required property
	from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: ethernet-switch@...07000 (brcm,bcm53011-srab): ports:port@8: 'phy-mode' is a required property
	from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: ethernet-switch@...07000 (brcm,bcm53011-srab): Unevaluated properties are not allowed ('ports' was unexpected)
	from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml#