linux-kernel - Re: [PATCH] media: staging: atomisp: stylefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfFiO4U3ge_xGw7JSwXtK0AwHO1hWLZdCv4huX0cey_+A@mail.gmail.com>
Date: Mon, 14 Jul 2025 20:53:23 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: sina hosseinizad <sina.hz@...il.com>
Cc: hansg@...nel.org, mchehab@...nel.org, sakari.ailus@...ux.intel.com, 
	andy@...nel.org, gregkh@...uxfoundation.org, linux-media@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH] media: staging: atomisp: stylefix

On Mon, Jul 14, 2025 at 5:27 PM sina hosseinizad <sina.hz@...il.com> wrote:
>
> change the spaces at the beginning of the line to tabs

You have to respect English grammar and punctuation.

>  int atomisp_css_video_configure_viewfinder(
> -    struct atomisp_sub_device *asd,
> +       struct atomisp_sub_device *asd,
>      unsigned int width, unsigned int height,
>      unsigned int min_width,
>      enum ia_css_frame_format format)

As a standalone this is useless change and just a churn. Try to find
something better to fix, please.

-- 
With Best Regards,
Andy Shevchenko