linux-kernel - Re: [PATCH] media: staging: atomisp: stylefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6519f649-82bd-4f58-b99a-731fb86aa1a6@suswa.mountain>
Date: Tue, 15 Jul 2025 00:09:33 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: sina hosseinizad <sina.hz@...il.com>
Cc: hansg@...nel.org, mchehab@...nel.org, sakari.ailus@...ux.intel.com,
	andy@...nel.org, gregkh@...uxfoundation.org,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-staging@...ts.linux.dev
Subject: Re: [PATCH] media: staging: atomisp: stylefix

On Mon, Jul 14, 2025 at 04:26:45PM +0200, sina hosseinizad wrote:
> change the spaces at the beginning of the line to tabs
> 
> Signed-off-by: sina hosseinizad <sina.hz@...il.com>

You probably want to capitalize your name.  It's supposed to be written
like you would write it on a legal document.  (These Signed off by lines
are supposed to be like a legal thing which says that you haven't stolen
any code or violated any copy rights in this patch).

> ---
> My first contribution to the linux kernel, so starting out with a stylefix
> ---
>  drivers/staging/media/atomisp/pci/atomisp_compat_css20.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
> index bc97fa2c374c..bd3a017490ef 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
> @@ -2347,7 +2347,7 @@ int atomisp_css_video_configure_output(struct atomisp_sub_device *asd,
>  }
>  
>  int atomisp_css_video_configure_viewfinder(
> -    struct atomisp_sub_device *asd,
> +	struct atomisp_sub_device *asd,
>      unsigned int width, unsigned int height,

The other lines don't match now.

regards,
dan carpenter

>      unsigned int min_width,
>      enum ia_css_frame_format format)
> -- 
> 2.39.5
>