linux-kernel - Re: [PATCH v5 10/14] dt-bindings: PCI: Add CIX Sky1 PCIe Root Complex bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6083e62-318f-4879-bac3-97ad26615458@cixtech.com>
Date: Mon, 14 Jul 2025 16:03:51 +0800
From: Hans Zhang <hans.zhang@...tech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: bhelgaas@...gle.com, lpieralisi@...nel.org, kw@...ux.com,
 mani@...nel.org, robh@...nel.org, kwilczynski@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, mpillai@...ence.com,
 fugang.duan@...tech.com, guoyin.chen@...tech.com, peter.chen@...tech.com,
 cix-kernel-upstream@...tech.com, linux-pci@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 10/14] dt-bindings: PCI: Add CIX Sky1 PCIe Root Complex
 bindings



On 2025/7/14 15:43, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL
> 
> On 03/07/2025 03:47, Hans Zhang wrote:
>>>>
>>>> We initially used the logic of Cadence common driver as follows:
>>>> drivers/pci/controller/cadence/pcie-cadence-host.c
>>>> of_property_read_u32(np, "vendor-id", &rc->vendor_id);
>>>>
>>>> of_property_read_u32(np, "device-id", &rc->device_id);
>>>>
>>>> So, can the code in Cadence be deleted?
>>>
>>> Don't know. If this is ABI, then not.
>>>
>>
>> According to my understanding, this is not ABI.
> 
> Huh? Then what is ABI, by your understanding?
> 

Dear Krzysztof,

I understand kernel ABI primarily refers to the stable binary contract 
between the kernel and userspace (e.g., syscalls, /sys/proc interfaces). 
Device tree properties are part of the boot-time hardware description 
consumed by drivers during initialization. They are not directly exposed 
to userspace as ABI interfaces.

If I understand wrongly, please correct me.


It was about half a year ago when I submitted the patch that could view 
LTSSM link status in dwc that I learned about the ABI. There are not 
many studies on this.

https://lore.kernel.org/linux-pci/20250123164944.GA1223935@bhelgaas/


Best regards,
Hans