linux-kernel - Re: [PATCH net-next 01/12] dt-bindings: ptp: add bindings for NETC Timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <169e742f-778e-4d42-b301-c954ecec170a@kernel.org>
Date: Mon, 14 Jul 2025 11:14:20 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Wei Fang <wei.fang@....com>
Cc: "F.S. Peng" <fushi.peng@....com>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
 "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
 <krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "richardcochran@...il.com" <richardcochran@...il.com>,
 Claudiu Manoil <claudiu.manoil@....com>,
 Vladimir Oltean <vladimir.oltean@....com>, Clark Wang
 <xiaoning.wang@....com>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
 "davem@...emloft.net" <davem@...emloft.net>,
 "edumazet@...gle.com" <edumazet@...gle.com>,
 "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>
Subject: Re: [PATCH net-next 01/12] dt-bindings: ptp: add bindings for NETC
 Timer

On 14/07/2025 11:11, Wei Fang wrote:
>>>>> +  nxp,pps-channel:
>>>>> +    $ref: /schemas/types.yaml#/definitions/uint8
>>>>> +    default: 0
>>>>> +    description:
>>>>> +      Specifies to which fixed interval period pulse generator is
>>>>> +      used to generate PPS signal.
>>>>> +    enum: [0, 1, 2]
>>>>
>>>> Cell phandle tells that. Drop property.
>>>
>>> Sorry, I do not understand what you mean, could you explain it in more
>>> detail?
>>
>> Use phandle cells for that - look at other PTP bindings.
> 
> Sorry, I did not find a reference in other PTP bindings. If I understand
> correctly, you mean I should add a specific cells property to this doc
> as follows, correct?
> 
> "#nxp,pps-channel-cells":
>     description: |
>       Specifies to which fixed interval period pulse generator is
>       used to generate PPS signal.
>     $ref: /schemas/types.yaml#/definitions/uint32
>     const: 1
> 

No. Is this a timestamper device? You really did not find a TXT document
describing this, in the same directory? Well, maybe it is not a
timestamper device, how do I know, your description should be clear here.

How does the other consumer - ethernet - reference this one here? Paste
complete DTS of this and users, otherwise it is just ping-pong
discussion where you put just a little effort to bounce back my question.

Best regards,
Krzysztof