linux-kernel - RE: [PATCH net-next 01/12] dt-bindings: ptp: add bindings for NETC Timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB85107A7E7EB7141BC8F2518A8854A@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Mon, 14 Jul 2025 09:56:27 +0000
From: Wei Fang <wei.fang@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: "F.S. Peng" <fushi.peng@....com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"richardcochran@...il.com" <richardcochran@...il.com>, Claudiu Manoil
	<claudiu.manoil@....com>, Vladimir Oltean <vladimir.oltean@....com>, Clark
 Wang <xiaoning.wang@....com>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>
Subject: RE: [PATCH net-next 01/12] dt-bindings: ptp: add bindings for NETC
 Timer

> On 14/07/2025 11:11, Wei Fang wrote:
> >>>>> +  nxp,pps-channel:
> >>>>> +    $ref: /schemas/types.yaml#/definitions/uint8
> >>>>> +    default: 0
> >>>>> +    description:
> >>>>> +      Specifies to which fixed interval period pulse generator is
> >>>>> +      used to generate PPS signal.
> >>>>> +    enum: [0, 1, 2]
> >>>>
> >>>> Cell phandle tells that. Drop property.
> >>>
> >>> Sorry, I do not understand what you mean, could you explain it in more
> >>> detail?
> >>
> >> Use phandle cells for that - look at other PTP bindings.
> >
> > Sorry, I did not find a reference in other PTP bindings. If I understand
> > correctly, you mean I should add a specific cells property to this doc
> > as follows, correct?
> >
> > "#nxp,pps-channel-cells":
> >     description: |
> >       Specifies to which fixed interval period pulse generator is
> >       used to generate PPS signal.
> >     $ref: /schemas/types.yaml#/definitions/uint32
> >     const: 1
> >
> 
> 
> No. Is this a timestamper device? You really did not find a TXT document
> describing this, in the same directory? Well, maybe it is not a
> timestamper device, how do I know, your description should be clear here.

I thought I should find the reference from YAML docs. So I did not look at
the TXT docs.

> 
> How does the other consumer - ethernet - reference this one here? Paste
> complete DTS of this and users, otherwise it is just ping-pong
> discussion where you put just a little effort to bounce back my question.

Below is the DTS node of enetc (ethernet device) and timer node.

enetc_port0: ethernet@0,0 {
	compatible = "pci1131,e101";
	reg = <0x000000 0 0 0 0>;
	pinctrl-names = "default";
	pinctrl-0 = <&pinctrl_enetc0>;
	phy-handle = <&ethphy0>;
	phy-mode = "rgmii-id";
	status = "okay";
};

netc_timer: ethernet@18,0 {
	compatible = "pci1131,ee02";
	reg = <0x00c000 0 0 0 0>;
	clocks = <&netc_system333m>;
	clock-names = "system";
};

Currently, the enetc driver uses the PCIe device number and function number
of the Timer to obtain the Timer device, so there is no related binding in DTS.
In the future, we plan to add phandle to the enetc document to bind enetc
and Timer, because there will be multiple Timer instances on subsequent
platforms.

But what I want to say is that "nxp,pps-channel" is used to specify which
channel/pin the NETC Timer device uses to output the Pulse Per Second
(PPS) signal. This function is independent of enetc (Ethernet device), so it
it is not used by enetc.