linux-kernel - Re: [PATCH v3 2/3] dt-bindings: leds: is31fl32xx: convert the binding to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA6zWZKRA2Qn3ajN9f9o_oBTZAgrx22gP28A5CHgx=+0jFrOKg@mail.gmail.com>
Date: Mon, 14 Jul 2025 10:16:29 +0100
From: Pawel Zalewski <pzalewski@...goodpenguin.co.uk>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Lee Jones <lee@...nel.org>, Pavel Machek <pavel@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, linux-leds@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Pavel Machek <pavel@....cz>, devicetree@...r.kernel.org, 
	Lucca Fachinetti <luccafachinetti@...il.com>
Subject: Re: [PATCH v3 2/3] dt-bindings: leds: is31fl32xx: convert the binding
 to yaml

> Driver as Linux driver or LED driver? If the first, then drop.
LED driver, might not be obvious, could change to controller,
however the datasheet refers to the device "LED driver".

> These should be people interested in this hardware, not subsystem
> maintainers.

I will let maintainers decide who should be included here perhaps ?

> Keep consistent quotes, either " or '. You made different choice for the
> same properties even...

Copied over from original poster, have not spotted that before, thanks.

> Pattern does not match entirely the reg constraints. 36 is 0x24.

Pattern allows for one or more hexadecimal values starting from 1,
so the second number should start from zero is the second error here.

Thanks !