linux-kernel - Re: [PATCH 1/2] crypto: engine: remove request batching support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <701ab192-9c96-43b8-805e-a8e9953f7abc@nxp.com>
Date: Tue, 15 Jul 2025 21:38:32 +0000
From: Horia Geanta <horia.geanta@....com>
To: Ovidiu Panait <ovidiu.panait.oss@...il.com>, "herbert@...dor.apana.org.au"
	<herbert@...dor.apana.org.au>, "davem@...emloft.net" <davem@...emloft.net>,
	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: "freude@...ux.ibm.com" <freude@...ux.ibm.com>, "dengler@...ux.ibm.com"
	<dengler@...ux.ibm.com>, "linux-s390@...r.kernel.org"
	<linux-s390@...r.kernel.org>, Pankaj Gupta <pankaj.gupta@....com>, Gaurav
 Jain <gaurav.jain@....com>, "arei.gonglei@...wei.com"
	<arei.gonglei@...wei.com>, "virtualization@...ts.linux.dev"
	<virtualization@...ts.linux.dev>
Subject: Re: [PATCH 1/2] crypto: engine: remove request batching support

On 7/11/2025 9:30 PM, Ovidiu Panait wrote:
> Remove request batching support from crypto_engine, as there are no
> drivers using this feature and it doesn't really work that well.
> 
> Instead of doing batching based on backlog, a more optimal approach
> would be for the user to handle the batching (similar to how IPsec
> can hook into GSO to get 64K of data each time or how block encryption
> can use unit sizes much greater than 4K).
> 
> Suggested-by: Herbert Xu <herbert@...dor.apana.org.au>
> Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@...il.com>
Reviewed-by: Horia Geantă <horia.geanta@....com>

Thanks,
Horia