linux-kernel - Re: [PATCH 1/2] crypto: engine: remove request batching support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aHosV3T9l0OQkKY0@gondor.apana.org.au>
Date: Fri, 18 Jul 2025 21:13:27 +1000
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Ovidiu Panait <ovidiu.panait.oss@...il.com>
Cc: davem@...emloft.net, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org, freude@...ux.ibm.com,
	dengler@...ux.ibm.com, linux-s390@...r.kernel.org,
	horia.geanta@....com, pankaj.gupta@....com, gaurav.jain@....com,
	arei.gonglei@...wei.com, virtualization@...ts.linux.dev
Subject: Re: [PATCH 1/2] crypto: engine: remove request batching support

On Fri, Jul 11, 2025 at 09:29:31PM +0300, Ovidiu Panait wrote:
> Remove request batching support from crypto_engine, as there are no
> drivers using this feature and it doesn't really work that well.
> 
> Instead of doing batching based on backlog, a more optimal approach
> would be for the user to handle the batching (similar to how IPsec
> can hook into GSO to get 64K of data each time or how block encryption
> can use unit sizes much greater than 4K).
> 
> Suggested-by: Herbert Xu <herbert@...dor.apana.org.au>
> Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@...il.com>
> ---
> Cc: freude@...ux.ibm.com
> Cc: dengler@...ux.ibm.com
> Cc: linux-s390@...r.kernel.org
> Cc: horia.geanta@....com
> Cc: pankaj.gupta@....com
> Cc: gaurav.jain@....com
> Cc: arei.gonglei@...wei.com
> Cc: virtualization@...ts.linux.dev
> 
>  arch/s390/crypto/paes_s390.c               |  2 +-
>  arch/s390/crypto/phmac_s390.c              |  2 +-
>  crypto/crypto_engine.c                     | 25 +---------------------
>  drivers/crypto/caam/jr.c                   |  3 +--
>  drivers/crypto/virtio/virtio_crypto_core.c |  2 +-
>  include/crypto/engine.h                    |  1 -
>  include/crypto/internal/engine.h           |  4 ----
>  7 files changed, 5 insertions(+), 34 deletions(-)

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt