linux-kernel - Re: [PATCH v3 1/5] panic: clean up code for console replay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aHWliJhyIZnq97Mm@U-2FWC9VHC-2323.local>
Date: Tue, 15 Jul 2025 08:49:12 +0800
From: Feng Tang <feng.tang@...ux.alibaba.com>
To: Askar Safin <safinaskar@...omail.com>
Cc: akpm@...ux-foundation.org, corbet@....net, john.ogness@...utronix.de,
	lance.yang@...ux.dev, linux-kernel@...r.kernel.org,
	paulmck@...nel.org, pmladek@...e.com, rostedt@...dmis.org
Subject: Re: [PATCH v3 1/5] panic: clean up code for console replay

Hi Askar Safin,

On Tue, Jul 15, 2025 at 12:09:40AM +0300, Askar Safin wrote:
> I just tested bit 5. It doesn't replay all console messages (i. e. everything printed to /dev/console ).
> Instead it merely replays kernel messages (i. e. printk/kmsg).
> So, please, rename PANIC_CONSOLE_REPLAY back to PANIC_PRINT_ALL_PRINTK_MSG or possibly to PANIC_KMSG_REPLAY.
> And update admin-guide/sysctl/kernel.rst

Thanks for trying the patch! 

Petr could have better understanding on this, as he have been working
on this for many years and maintained printk.

I brought out the name for kernel space debugging, to replay all the
printk message on the tty console I have. 

My understanding is, 'console' have kind of different meaning in kernel
space than just /dev/console. In printk.c, you can see 'console' is
used everywhere,  which are mostly bound to kernel message.like
console_try_replay_all(), console_flush_all(), console_flush_on_panic(),
which are consistent with the new name suggested by Petr.

Thanks,
Feng

> 
> --
> Askar Safin