linux-kernel - Re: [PATCH v3 1/5] panic: clean up code for console replay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1980ba9224c.11f5e5a9635585.8635674808464045994@zohomail.com>
Date: Tue, 15 Jul 2025 05:18:10 +0400
From: Askar Safin <safinaskar@...omail.com>
To: "Feng Tang" <feng.tang@...ux.alibaba.com>
Cc: "akpm" <akpm@...ux-foundation.org>, "corbet" <corbet@....net>,
	"john.ogness" <john.ogness@...utronix.de>,
	"lance.yang" <lance.yang@...ux.dev>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	"paulmck" <paulmck@...nel.org>, "pmladek" <pmladek@...e.com>,
	"rostedt" <rostedt@...dmis.org>
Subject: Re: [PATCH v3 1/5] panic: clean up code for console replay

 ---- On Tue, 15 Jul 2025 04:49:12 +0400  Feng Tang <feng.tang@...ux.alibaba.com> wrote --- 
 > Thanks for trying the patch! 
I didn't try it. :) I merely run normal mainline or distro kernel in qemu.

 > My understanding is, 'console' have kind of different meaning in kernel
 > space than just /dev/console. In printk.c, you can see 'console' is
 > used everywhere,  which are mostly bound to kernel message.like
 > console_try_replay_all(), console_flush_all(), console_flush_on_panic(),
 > which are consistent with the new name suggested by Petr.
Okay, I agree.

But I still kindly ask you to revert changes to Documentation/admin-guide/kernel-parameters.txt .
Previous documentation is better.
admin-guide is written for admins, not for kernel developers. And they understand "console" as /dev/console .

I run kernel with panic_print=32 in hope that this will flush console (i. e. /dev/console), because this is how I interpreted
your patched documentation. And I got different effect.

--
Askar Safin
https://types.pl/@safinaskar