linux-kernel - Re: [PATCH 4/7] hwmon: iio: Refactor scale calculation into helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aHYSwVeC33qvb_-o@smile.fi.intel.com>
Date: Tue, 15 Jul 2025 11:35:13 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Sean Anderson <sean.anderson@...ux.dev>
Cc: Jonathan Cameron <jic23@...nel.org>, Jean Delvare <jdelvare@...e.com>,
	Guenter Roeck <linux@...ck-us.net>, linux-iio@...r.kernel.org,
	linux-hwmon@...r.kernel.org, Andy Shevchenko <andy@...nel.org>,
	Nuno Sá <nuno.sa@...log.com>,
	linux-kernel@...r.kernel.org, David Lechner <dlechner@...libre.com>
Subject: Re: [PATCH 4/7] hwmon: iio: Refactor scale calculation into helper

On Mon, Jul 14, 2025 at 09:20:20PM -0400, Sean Anderson wrote:
> Add a function to determine the scale parameter, since it will soon be
> used in several places.

...

> + * Return: scale of @chan

Needs a bit of elaboration. Can it be negative? What is the unit of scale
(just plain integer multiplier)? Should it be (always) signed?

...

> +	/* mili-Watts to micro-Watts conversion */
> +	if (type == IIO_POWER)
> +		return 1000;

MICROWATT_PER_MILLIWATT ?

-- 
With Best Regards,
Andy Shevchenko