linux-kernel - Re: [PATCH v3 0/2] hwmon: Add support for MPS mp2869,mp29502 chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a6c43c7-3f77-4d47-9913-54c50cb59e9d@roeck-us.net>
Date: Wed, 16 Jul 2025 12:44:43 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: wenswang@...h.net, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, jdelvare@...e.com, corbet@....net
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hwmon@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v3 0/2] hwmon: Add support for MPS mp2869,mp29502 chip

On 7/9/25 02:27, wenswang@...h.net wrote:
> From: Wensheng Wang <wenswang@...h.net>
> 
> Add mp2869,mp29502 driver in hwmon and add dt-bindings for them.
> 
> V2 -> V3:
>      merge patches for MP29502 and MP2869

Why ? It only makes review more difficult.

Either case, I now have submissions for two drivers supporting MP2869
(or MP2869). One of them also supports MP29612A. That needs to be consolidated,
and I guess I'll need to spend a lot of time trying to figure out if separate
drivers for all those chips are really needed. That is going to take a while.

Guenter

> 
> V1 -> V2:
>      add Rob's Acked-by
> 
> Wensheng Wang (2):
>    dt-bindings: hwmon: Add MPS mp2869 series and mp29502
>    hwmon: add MP2869 series and MP29502 driver
> 
>   .../devicetree/bindings/trivial-devices.yaml  |  10 +
>   Documentation/hwmon/index.rst                 |   2 +
>   Documentation/hwmon/mp2869.rst                | 175 +++++
>   Documentation/hwmon/mp29502.rst               |  93 +++
>   MAINTAINERS                                   |   9 +
>   drivers/hwmon/pmbus/Kconfig                   |  18 +
>   drivers/hwmon/pmbus/Makefile                  |   2 +
>   drivers/hwmon/pmbus/mp2869.c                  | 711 ++++++++++++++++++
>   drivers/hwmon/pmbus/mp29502.c                 | 670 +++++++++++++++++
>   9 files changed, 1690 insertions(+)
>   create mode 100644 Documentation/hwmon/mp2869.rst
>   create mode 100644 Documentation/hwmon/mp29502.rst
>   create mode 100644 drivers/hwmon/pmbus/mp2869.c
>   create mode 100644 drivers/hwmon/pmbus/mp29502.c
>