linux-kernel - Re: [PATCH v3 2/2] hwmon: add MP2869 series and MP29502 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <039c31c3-af15-46e0-98fb-f3a54fcf73e5@roeck-us.net>
Date: Wed, 16 Jul 2025 13:30:51 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: wenswang@...h.net, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, jdelvare@...e.com, corbet@....net
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hwmon@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v3 2/2] hwmon: add MP2869 series and MP29502 driver

On 7/9/25 02:34, wenswang@...h.net wrote:
> From: Wensheng Wang <wenswang@...h.net>
> 
> Add support for MPS VR mp2869 series and mp29502 controller. The
> driver exposes telemetry and limit value readings and writtings.
> 
> Signed-off-by: Wensheng Wang <wenswang@...h.net>
> ---
> V2 -> V3:
>      merge patches for MP29502 and MP2869
> 
> V1 -> V2:
>      add Rob's Acked-by
> 
>   Documentation/hwmon/index.rst   |   2 +
>   Documentation/hwmon/mp2869.rst  | 175 ++++++++
>   Documentation/hwmon/mp29502.rst |  93 +++++
>   MAINTAINERS                     |   9 +
>   drivers/hwmon/pmbus/Kconfig     |  18 +
>   drivers/hwmon/pmbus/Makefile    |   2 +
>   drivers/hwmon/pmbus/mp2869.c    | 711 ++++++++++++++++++++++++++++++++
>   drivers/hwmon/pmbus/mp29502.c   | 670 ++++++++++++++++++++++++++++++
>   8 files changed, 1680 insertions(+)
>   create mode 100644 Documentation/hwmon/mp2869.rst
>   create mode 100644 Documentation/hwmon/mp29502.rst
>   create mode 100644 drivers/hwmon/pmbus/mp2869.c
>   create mode 100644 drivers/hwmon/pmbus/mp29502.c
> 
> diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
> index b45bfb4ebf30..ebc5c92e50b0 100644
> --- a/Documentation/hwmon/index.rst
> +++ b/Documentation/hwmon/index.rst
> @@ -172,8 +172,10 @@ Hardware Monitoring Kernel Drivers
>      menf21bmc
>      mlxreg-fan
>      mp2856
> +   mp2869
>      mp2888
>      mp2891
> +   mp29502
>      mp2975
>      mp2993
>      mp5023
> diff --git a/Documentation/hwmon/mp2869.rst b/Documentation/hwmon/mp2869.rst
> new file mode 100644
> index 000000000000..2d9d65fc86b6
> --- /dev/null
> +++ b/Documentation/hwmon/mp2869.rst
> @@ -0,0 +1,175 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
> +Kernel driver mp2869
> +====================
> +
> +Supported chips:
> +
> +  * MPS mp2869
> +
> +    Prefix: 'mp2869'
> +
> +  * MPS mp29608
> +
> +    Prefix: 'mp29608'
> +
> +  * MPS mp29612
> +
> +    Prefix: 'mp29612'
> +
> +  * MPS mp29816
> +
> +    Prefix: 'mp29816'
> +
> +Author:
> +
> +	Wensheng Wang <wenswang@...h.net>
> +
> +Description
> +-----------
> +
> +This driver implements support for Monolithic Power Systems, Inc. (MPS)
> +MP2869 Dual Loop Digital Multi-phase Controller.
> +
> +Device compliant with:
> +
> +- PMBus rev 1.3 interface.
> +
> +The driver exports the following attributes via the 'sysfs' files
> +for input voltage:
> +
> +**in1_input**
> +
> +**in1_label**
> +
> +**in1_crit**
> +
> +**in1_crit_alarm**
> +
> +**in1_lcrit**
> +
> +**in1_lcrit_alarm**
> +
> +**in1_min**
> +
> +**in1_min_alarm**
> +
> +The driver provides the following attributes for output voltage:
> +
> +**in2_input**
> +
> +**in2_label**
> +
> +**in2_crit**
> +
> +**in2_crit_alarm**
> +
> +**in2_lcrit**
> +
> +**in2_lcrit_alarm**
> +
> +**in3_input**
> +
> +**in3_label**
> +
> +**in3_crit**
> +
> +**in3_crit_alarm**
> +
> +**in3_lcrit**
> +
> +**in3_lcrit_alarm**
> +
> +The driver provides the following attributes for input current:
> +
> +**curr1_input**
> +
> +**curr1_label**
> +
> +**curr2_input**
> +
> +**curr2_label**
> +
> +The driver provides the following attributes for output current:
> +
> +**curr3_input**
> +
> +**curr3_label**
> +
> +**curr3_crit**
> +
> +**curr3_crit_alarm**
> +
> +**curr3_max**
> +
> +**curr3_max_alarm**
> +
> +**curr4_input**
> +
> +**curr4_label**
> +
> +**curr4_crit**
> +
> +**curr4_crit_alarm**
> +
> +**curr4_max**
> +
> +**curr4_max_alarm**
> +
> +The driver provides the following attributes for input power:
> +
> +**power1_input**
> +
> +**power1_label**
> +
> +**power2_input**
> +
> +**power2_label**
> +
> +The driver provides the following attributes for output power:
> +
> +**power3_input**
> +
> +**power3_label**
> +
> +**power3_input**
> +
> +**power3_label**
> +
> +**power3_max**
> +
> +**power3_max_alarm**
> +
> +**power4_input**
> +
> +**power4_label**
> +
> +**power4_input**
> +
> +**power4_label**
> +
> +**power4_max**
> +
> +**power4_max_alarm**
> +
> +The driver provides the following attributes for temperature:
> +
> +**temp1_input**
> +
> +**temp1_crit**
> +
> +**temp1_crit_alarm**
> +
> +**temp1_max**
> +
> +**temp1_max_alarm**
> +
> +**temp2_input**
> +
> +**temp2_crit**
> +
> +**temp2_crit_alarm**
> +
> +**temp2_max**
> +
> +**temp2_max_alarm**
> diff --git a/Documentation/hwmon/mp29502.rst b/Documentation/hwmon/mp29502.rst
> new file mode 100644
> index 000000000000..7743056f0aa6
> --- /dev/null
> +++ b/Documentation/hwmon/mp29502.rst
> @@ -0,0 +1,93 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
> +Kernel driver mp29502
> +====================
> +
> +Supported chips:
> +
> +  * MPS mp29502
> +
> +    Prefix: 'mp29502'
> +
> +Author:
> +
> +	Wensheng Wang <wenswang@...h.net>
> +
> +Description
> +-----------
> +
> +This driver implements support for Monolithic Power Systems, Inc. (MPS)
> +MP29502 Digital Multi-phase Controller.
> +
> +Device compliant with:
> +
> +- PMBus rev 1.3 interface.
> +
> +The driver exports the following attributes via the 'sysfs' files
> +for input voltage:
> +
> +**in1_input**
> +
> +**in1_label**
> +
> +**in1_crit**
> +
> +**in1_crit_alarm**
> +
> +The driver provides the following attributes for output voltage:
> +
> +**in2_input**
> +
> +**in2_label**
> +
> +**in2_crit**
> +
> +**in2_crit_alarm**
> +
> +**in2_lcrit**
> +
> +**in2_lcrit_alarm**
> +
> +The driver provides the following attributes for input current:
> +
> +**curr1_input**
> +
> +**curr1_label**
> +
> +The driver provides the following attributes for output current:
> +
> +**curr2_input**
> +
> +**curr2_label**
> +
> +**curr2_crit**
> +
> +**curr2_crit_alarm**
> +
> +**curr2_max**
> +
> +**curr2_max_alarm**
> +
> +The driver provides the following attributes for input power:
> +
> +**power1_input**
> +
> +**power1_label**
> +
> +The driver provides the following attributes for output power:
> +
> +**power2_input**
> +
> +**power2_label**
> +
> +The driver provides the following attributes for temperature:
> +
> +**temp1_input**
> +
> +**temp1_crit**
> +
> +**temp1_crit_alarm**
> +
> +**temp1_max**
> +
> +**temp1_max_alarm**
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 240793fbe64b..b4377f0eb3a1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16839,6 +16839,15 @@ F:	scripts/module*
>   F:	tools/testing/selftests/kmod/
>   F:	tools/testing/selftests/module/
>   
> +MONOLITHIC POWER SYSTEM MULTI-PHASE CONTROLLER DRIVER
> +M:	Wensheng Wang <wenswang@...h.net>
> +L:	linux-hwmon@...r.kernel.org
> +S:	Maintained
> +F:	Documentation/hwmon/mp2869.rst
> +F:	Documentation/hwmon/mp29502.rst
> +F:	drivers/hwmon/pmbus/mp2869.c
> +F:	drivers/hwmon/pmbus/mp29502.c
> +
>   MONOLITHIC POWER SYSTEM PMIC DRIVER
>   M:	Saravanan Sekar <sravanhome@...il.com>
>   S:	Maintained
> diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
> index 441f984a859d..d0bdd1b5feb6 100644
> --- a/drivers/hwmon/pmbus/Kconfig
> +++ b/drivers/hwmon/pmbus/Kconfig
> @@ -364,6 +364,15 @@ config SENSORS_MP2856
>   	  This driver can also be built as a module. If so, the module will
>   	  be called mp2856.
>   
> +config SENSORS_MP2869
> +	tristate "MPS MP2869"
> +	help
> +	  If you say yes here you get hardware monitoring support for MPS
> +	  MP2869 Dual Loop Digital Multi-Phase Controller.
> +
> +	  This driver can also be built as a module. If so, the module will
> +	  be called mp2869.
> +
>   config SENSORS_MP2888
>   	tristate "MPS MP2888"
>   	help
> @@ -382,6 +391,15 @@ config SENSORS_MP2891
>         This driver can also be built as a module. If so, the module will
>         be called mp2891.
>   
> +config SENSORS_MP29502
> +	tristate "MPS MP29502"
> +	help
> +	  If you say yes here you get hardware monitoring support for MPS
> +	  MP29502 Dual Loop Digital Multi-Phase Controller.
> +
> +	  This driver can also be built as a module. If so, the module will
> +	  be called mp29502.
> +
>   config SENSORS_MP2975
>   	tristate "MPS MP2975"
>   	help
> diff --git a/drivers/hwmon/pmbus/Makefile b/drivers/hwmon/pmbus/Makefile
> index 29cd8a3317d2..4c5ff3f32c5e 100644
> --- a/drivers/hwmon/pmbus/Makefile
> +++ b/drivers/hwmon/pmbus/Makefile
> @@ -37,8 +37,10 @@ obj-$(CONFIG_SENSORS_MAX31785)	+= max31785.o
>   obj-$(CONFIG_SENSORS_MAX34440)	+= max34440.o
>   obj-$(CONFIG_SENSORS_MAX8688)	+= max8688.o
>   obj-$(CONFIG_SENSORS_MP2856)	+= mp2856.o
> +obj-$(CONFIG_SENSORS_MP2869)	+= mp2869.o
>   obj-$(CONFIG_SENSORS_MP2888)	+= mp2888.o
>   obj-$(CONFIG_SENSORS_MP2891)	+= mp2891.o
> +obj-$(CONFIG_SENSORS_MP29502)	+= mp29502.o
>   obj-$(CONFIG_SENSORS_MP2975)	+= mp2975.o
>   obj-$(CONFIG_SENSORS_MP2993)	+= mp2993.o
>   obj-$(CONFIG_SENSORS_MP5023)	+= mp5023.o
> diff --git a/drivers/hwmon/pmbus/mp2869.c b/drivers/hwmon/pmbus/mp2869.c
> new file mode 100644
> index 000000000000..af233ffd5230
> --- /dev/null
> +++ b/drivers/hwmon/pmbus/mp2869.c
> @@ -0,0 +1,711 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Hardware monitoring driver for MPS Multi-phase Digital VR Controllers(MP2869)
> + */
> +
> +#include <linux/bitfield.h>
> +#include <linux/i2c.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include "pmbus.h"
> +
> +#define MFR_READ_PIN_EST	0x94
> +#define MFR_READ_IIN_EST	0x95
> +#define MFR_VOUT_SCALE_LOOP	0x29

This is a standard register.

> +#define MFR_SVI3_IOUT_PRT	0x67
> +#define STATUS_MFR_SPECIFIC	0x80

This is a standard register.

Guenter