linux-kernel - [PATCH 1/1] ASoC: codec: tlv320aic32x4: Fix reset GPIO check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250716065708.4041153-1-alexander.stein@ew.tq-group.com>
Date: Wed, 16 Jul 2025 08:57:07 +0200
From: Alexander Stein <alexander.stein@...tq-group.com>
To: Shenghao Ding <shenghao-ding@...com>,
	Kevin Lu <kevin-lu@...com>,
	Baojun Xu <baojun.xu@...com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Peng Fan <peng.fan@....com>,
	Linus Walleij <linus.walleij@...aro.org>
Cc: Alexander Stein <alexander.stein@...tq-group.com>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH 1/1] ASoC: codec: tlv320aic32x4: Fix reset GPIO check

rstn_gpio being a GPIO descriptor the check is wrong (inverted) for
releasing the reset of the codec.

Fixes: 790d5f8ee6f2 ("ASoC: codec: tlv320aic32x4: Convert to GPIO descriptors")
Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
---
AFAICT this bug was introduced on v2 of the series which changed the
validity check

 sound/soc/codecs/tlv320aic32x4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/tlv320aic32x4.c b/sound/soc/codecs/tlv320aic32x4.c
index 3b89980e9bcf2..7399080f8580c 100644
--- a/sound/soc/codecs/tlv320aic32x4.c
+++ b/sound/soc/codecs/tlv320aic32x4.c
@@ -1388,7 +1388,7 @@ int aic32x4_probe(struct device *dev, struct regmap *regmap,
 		return ret;
 	}
 
-	if (!aic32x4->rstn_gpio) {
+	if (aic32x4->rstn_gpio) {
 		ndelay(10);
 		/* deassert reset */
 		gpiod_set_value_cansleep(aic32x4->rstn_gpio, 0);
-- 
2.43.0